Bug 2918 - Notification Popup icon is hardcoded
Summary: Notification Popup icon is hardcoded
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/Notification (show other bugs)
Version: 3.9.2
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-05-09 12:09 UTC by ochosi
Modified: 2016-09-01 19:43 UTC (History)
1 user (show)

See Also:


Attachments

Description ochosi 2013-05-09 12:09:47 UTC
Hi,
currently it isn't possible to use an icon from the icon-theme for the "New-Mail" notification popups as they are hardcoded:
http://git.claws-mail.org/?p=claws.git;a=blob;f=src/plugins/notification/notification_pixbuf.c;h=c14ce2454a693d426587042ca6dcf82179dc0964;hb=master#l36

Would be nice to get that resolved and using an icon that could be overridden by the gtk-icon-theme. Thanks!
Comment 1 Paul 2013-08-06 05:55:52 UTC
I think you must be talking about GNOME_STOCK_MAIL_NEW because there is no MAIL_NEW stock icon in GTK+. Since Claws is not a gnome app, this won't happen. However, it is possible to modify the icon by using a Claws Mail theme.
Comment 2 Holger Berndt 2013-08-06 21:09:46 UTC
Paul, this is not about the icon in the tray, it is about the icon of the popup itself (see e.g. [1]). This one is not themable, but hardcoded to be the Claws Mail logo. 

Reopening as I don't think this enhancement request is invalid. On the other hand it's only fair to say that I am unlikely to work on that anytime soon, so feel free to put the bug on WONTFIX if you want it closed.

[1] http://www.claws-mail.org/img/notification/notification_trayicon1.png
Comment 3 Ricardo Mones 2015-08-04 10:29:48 UTC
This is fixable by appliying last patch¹ of bug 3437²;

I had no time to review it, and was not applied to 3.12.0, but I'm reopening it. 

Lets see if I can find time for next release ;-)

¹ http://www.thewildbeast.co.uk/claws-mail/bugzilla/attachment.cgi?id=1525&action=diff
² http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3437
Comment 4 users 2016-09-01 19:42:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2016-09-01 19:42:02.941825457 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d3b60aded0edcd3ef3ea1cd725b7149779c685f4
Merge: a10423d db2ee15
Author: Colin Leroy <colin@colino.net>
Date:   Thu Sep 1 19:42:02 2016 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=db2ee150ef10f77d1b724a9cdf93df890cafc534
Author: Ricardo Mones <ricardo@mones.org>
Date:   Thu Sep 1 19:40:31 2016 +0200

    Fix bug #2918: Notification Popup icon is hardcoded
    
    Also fixes last part of bug #3437 by removing the call to deprecated
    function gdk_pixbuf_new_from_inline and not using a raw pixmap.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=fcfeb30db6fb32972acb57aec3c8cde7978e8f0e
Author: Ricardo Mones <ricardo@mones.org>
Date:   Thu Sep 1 19:39:46 2016 +0200

    Add 64x64 icon version to stock pixmaps
    
    Icon data purloined from last patch of #3437 by Christian Hesse.

Note You need to log in before you can comment on or make changes to this bug.