Created attachment 1517 [details] fix inconsistent use of tabs and spaces in indentation I sent most of this to the mailing list but nobody cared... So uploading here.
Created attachment 1518 [details] add *.tar.xz (xz compressed source tarball) to .gitignore
Created attachment 1519 [details] fix type in yacc file
Created attachment 1520 [details] remove unused variables
Created attachment 1521 [details] do not redefine MIN and MAX
Created attachment 1522 [details] remove useless rule
Created attachment 1523 [details] remove unused variable
Created attachment 1524 [details] remove unused code relating to old unsupported version of libarchive
Created attachment 1525 [details] replace raw logo with xpm and fix deprecated gdk_pixbuf_new_from_inline
I pushed the changes to a branch on github: https://github.com/eworm-de/claws-mail/commits/various-cleanups
Last patch still not applied to master, may fix bug 2918.
The last patch still hardcodes the icon, though in another format. (And it has an extra issue: This does support transparency on/off only, no real alpha channel, so icon borders are ugly.) Probably it would be worth it installing the icon to /usr/share/icons/ and selecting by name.
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2016-09-01 19:42:02.941825457 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d3b60aded0edcd3ef3ea1cd725b7149779c685f4 Merge: a10423d db2ee15 Author: Colin Leroy <colin@colino.net> Date: Thu Sep 1 19:42:02 2016 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=db2ee150ef10f77d1b724a9cdf93df890cafc534 Author: Ricardo Mones <ricardo@mones.org> Date: Thu Sep 1 19:40:31 2016 +0200 Fix bug #2918: Notification Popup icon is hardcoded Also fixes last part of bug #3437 by removing the call to deprecated function gdk_pixbuf_new_from_inline and not using a raw pixmap. http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=fcfeb30db6fb32972acb57aec3c8cde7978e8f0e Author: Ricardo Mones <ricardo@mones.org> Date: Thu Sep 1 19:39:46 2016 +0200 Add 64x64 icon version to stock pixmaps Icon data purloined from last patch of #3437 by Christian Hesse.
(In reply to comment #11) > The last patch still hardcodes the icon, though in another format. (And it > has an extra issue: This does support transparency on/off only, no real > alpha channel, so icon borders are ugly.) Right, but that's a general problem of internal theme, not fixable until its format is switched to PNG (RFE #3488) or something better. > Probably it would be worth it installing the icon to /usr/share/icons/ and > selecting by name. Now is a stock icon, so is theme-able in PNG format, if somebody feels it's too ugly for their visual tastes :)