Created attachment 2302 [details] An email with an HTML part with remote images Hello, In my configuration, I set for the Fancy plugin: "Enable loading of remote content": Off "Display embedded images": On Or, in clawsrc: [fancy] enable_images=1 enable_remote_content=0 But I see that Fancy does load remote images. That is, when I open the HTML part in the mail, remote images are loaded automatically, with no need for any further interaction on my part. (I marked this issue as "major" because it looks like a privacy/security issue, I apologize if this is incorrect) (Issue 4361 looks related but it is about another plugin) Attaching a message where this manifests for completeness, but I believe these are common enough...
This is a change outside of the plugin.
Comment on attachment 2302 [details] An email with an HTML part with remote images You have this configured: "Display embedded images": On This means that if all images are embedded they will be loaded.
On this system, since webkit2gtk3 2.38.0 (it seems) this problem has arisen. Loading an html part now prints on the console: ** (claws-mail:3178): CRITICAL **: 12:39:13.883: void webkit_website_data_manager_set_network_proxy_settings(WebKitWebsiteDataManager*, WebKitNetworkProxyMode, WebKitNetworkProxySettings*): assertion '(proxyMode != WEBKIT_NETWORK_PROXY_MODE_CUSTOM && !proxySettings) || (proxyMode == WEBKIT_NETWORK_PROXY_MODE_CUSTOM && proxySettings)' failed So it seems that the proxy cheat to block remote content is no longer working. It seems that we now need to do this: * Connect to WebKitWebExtension::page-created signal * Get the WebKitWebPage and connect to WebKitWebPage::send-request signal * Return TRUE to block the request
Definitely not related to bug #4361, though.
(In reply to Paul from comment #4) Didn't someone from the webkit team for some time ago explained exactly the same as you? He explained our current solution was using deprecated features in webkit?
Yes, I was contacted directly, and passed on this info to the devel ml. Unfortunately, that time is now upon us. Patches welcome.
(In reply to Michael Rasmussen from comment #5) BTW, it's not that our solution was using deprecated features, it's just that our solution was using webkit proxy is a way that it was never intended to be used, and this misuse is now no longer giving the result we acquired.
fixed in git.