Bug 4517 - Thread safety issues in signature checking code
Summary: Thread safety issues in signature checking code
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (Windows)
Classification: Unclassified
Component: default (show other bugs)
Version: 4.1.0
Hardware: PC Windows 10
: P3 normal
Assignee: Jonathan Boeing
URL:
Depends on:
Blocks:
 
Reported: 2021-08-09 09:06 UTC by Jonathan Boeing
Modified: 2021-11-16 22:39 UTC (History)
0 users

See Also:

Attachments
stack trace of the crash (6.93 KB, text/plain)
2021-08-09 09:06 UTC, Jonathan Boeing 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jonathan Boeing 2021-08-09 09:06:56 UTC 
Created attachment 2237 [details]
stack trace of the crash

There's a race condition between applying preferences and rechecking the signature of an open message that can cause a crash.  It's finicky to reproduce, but:

1. Open a signed message
2. Open the preferences window
3. Under Display -> Fonts toggle "Derive small and bold..." and hit Apply

Step 3 usually needs to be repeated a few times.  Having a compose window open seems to help reproduce it, but that's probably just coincidence.
Comment 1 Paul 2021-08-19 09:54:30 UTC 
No crash here.
Comment 2 Jonathan Boeing 2021-10-29 17:44:01 UTC 
The core problem is thread safety issues in the signature checking code.  Crashes can also be triggered by switching messages quickly or rechecking the signature quickly.

GPG takes much longer to check the signature on Windows than Linux, so Windows is more prone to the crash.
Note You need to log in before you can comment on or make changes to this bug.