:wave: I was helping upgrading the homebrew formula to use the latest release artifact, 4.0.0, but I have run into some build issue below and I might need some help understanding it. ``` Last 15 lines from /Users/rchen/Library/Logs/Homebrew/claws-mail/02.make: typedef struct _AtkSocket AtkSocket; ^ 6 errors generated. make[3]: *** [compose.o] Error 1 make[3]: *** Waiting for unfinished jobs.... ``` Also the changes are captured in this PR, https://github.com/Homebrew/homebrew-core/pull/81129. Feel free to come to the github PR to discuss details. Thanks! --- P.S. it is the general build issue so I dont want component that I should put into. :(
Atk is a dependency of gtk. This is not a claws-mail bug, but a problem with your buildchain. You need to install Atk.
Created attachment 2273 [details] Fix compile on non-X11 platforms The original issue description is incomplete. This is the actual error: compose.c:374:8: error: unknown type name 'GtkSocket'; did you mean 'AtkSocket'? (GtkSocket *socket, ^~~~~~~~~ AtkSocket I've attached a patch which fixes the issue for me.
(In reply to Bo from comment #2) Your patch does not take into account wayland, which is also not X11 but supports GtkSocket.
The patch was developed with information from Gtk3 documentation which explicitly states that GDK_WINDOWING_X11 was the correct check: https://docs.gtk.org/gtk3/class.Socket.html I checked the GtkSocket header in my Gtk3 installation and it also guarded by GDK_WINDOWING_X11: https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.33/gtk/gtksocket.h If the above is wrong, or a distribution of Gtk3 exists with Wayland support for GtkSocket, then fair enough but I don't know about it nor have the setup anyway to test Wayland - I'm very sorry.
Just to note here since this issue has been linked to in a couple places: a similar patch has now been applied in dd4c4e5152235f9f4f319cc9fdad9227ebf688c9 so this is now fixed. https://git.claws-mail.org/?p=claws.git;a=commit;h=dd4c4e5152235f9f4f319cc9fdad9227ebf688c9