Bug 4482 - Fancy ignores links with target="_blank"
Summary: Fancy ignores links with target="_blank"
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins/Fancy (show other bugs)
Version: 4.0.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2021-05-19 16:58 UTC by Johan Vromans
Modified: 2021-05-20 01:26 UTC (History)
2 users (show)

See Also:

Attachments
Message that shows the behaviour (11.90 KB, application/mbox)
2021-05-19 16:58 UTC, Johan Vromans 		Details
Fancy viewer: open in external viewer if target is specified in link. (1.66 KB, patch)
2021-05-19 19:58 UTC, Steve Randall 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Johan Vromans 2021-05-19 16:58:18 UTC 
Created attachment 2211 [details]
Message that shows the behaviour

Fancy seems to ignore links that have target="_blank".

I've been wondering for a while why some links were followed, and other links ignored so I decided to dive into it.

The attached message shows the behaviour. At the end, there are two identical links:

<p> <a target="_blank" href="https://groups.io/g/ChordPro/message/658">View/Reply Online (#658)</a></p>
<p> <a href="https://groups.io/g/ChordPro/message/658">View/Reply Online (#658)</a></p>

Clicking on the first link does nothing. Clicking on the second link works.
Comment 1 Steve Randall 2021-05-19 19:58:02 UTC 
Created attachment 2212 [details]
Fancy viewer: open in external viewer if target is specified in link.

This has been bugging me for a while. Thanks for the test case.

Patch is against branch gtk3.
Comment 2 Michael Rasmussen 2021-05-20 01:25:00 UTC 
Fixed with commit 251d9c2abe84debbb488fa8a6d40fe1436abbd12
Note You need to log in before you can comment on or make changes to this bug.