Hello! On latest master, scan-build[0] reports numerous memory errors and logic errors besides other issues. Here is the scan-build report: https://rootkea.gitlab.io/claws/scan-build/ And this is the .gitlab-ci.yml which generated this report: https://gitlab.com/rootkea/claws/-/blob/gitlab-scan-build/.gitlab-ci.yml [0] https://clang-analyzer.llvm.org/scan-build.html Regards, Avinash Sonawane (rootKea) PICT Pune
Patches also welcome.
There are some, perhaps many, false positives in your report. I'll close this until a more nuanced approach to finding errors is peformed. In the meantime, if you want to explore the list, please feel free to submit patches.
> There are some, perhaps many, false positives in your report. May be. But there are many genuine bugs. I just picked this random bug found by scan-build[0]: https://rootkea.gitlab.io/claws/scan-build/report-addritem.c-addritem_copy_item_folder-6-1.html#EndPath which is clearly a memory leak. There are many (37 memory leaks, 58 use-after-free etc.) like these in the scan-build report[1]. One can select by type of bugs if they want. I don't think marking this bug report as "Resolved" is apt. Thanks! [0] https://clang-analyzer.llvm.org/scan-build.html [1] https://rootkea.gitlab.io/claws/scan-build/