Bug 4454 - Build error: non-void function 'xface_get_from_header' should return a value
Summary: Build error: non-void function 'xface_get_from_header' should return a value
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.18.0
Hardware: All All
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2021-03-05 04:12 UTC by Avinash Sonawane
Modified: 2021-07-19 18:32 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Avinash Sonawane 2021-03-05 04:12:21 UTC 
Hello!

While building the latest git master with clang the build fails:

./gtkutils.c:1093:2: error: non-void function 'xface_get_from_header' should return a value [-Wreturn-type]
        cm_return_if_fail(sizeof(xface) < 0);
        ^

Also I don't get this line of code. Shouldn't we be checking `o_xface` instead of `xface` or am I missing something? And also the condition expression...

Regards,
Avinash Sonawane (rootKea)
PICT Pune
Note You need to log in before you can comment on or make changes to this bug.