Bug 4434 - fancy plugin: load progress bar may not be shown
Summary: fancy plugin: load progress bar may not be shown
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins/Fancy (show other bugs)
Version: 4.0.0
Hardware: PC Linux
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2021-01-27 17:41 UTC by Steve Randall
Modified: 2021-01-29 10:24 UTC (History)
0 users

See Also:

Attachments
Let fancy viewer progress bar expand. (1.07 KB, patch)
2021-01-27 17:41 UTC, Steve Randall 		Details | Diff
Make sure fancy viewer load progress bar is visible. (1015 bytes, patch)
2021-01-28 14:20 UTC, Steve Randall 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Steve Randall 2021-01-27 17:41:45 UTC 
Created attachment 2170 [details]
Let fancy viewer progress bar expand.

With certain themes, the load progress bar is not shown. (I believe these themes probably aren't setting an appropriate minimum width.) An easy fix is to allow the bar to expand.
Comment 1 Paul 2021-01-28 08:56:18 UTC 
What about using

gtk_widget_set_size_request(GTK_WIDGET(viewer->progress), 25, -1);

just after

viewer->progress = gtk_progress_bar_new();

Does that work for those problem themes?
Comment 2 Steve Randall 2021-01-28 14:20:26 UTC 
Created attachment 2171 [details]
Make sure fancy viewer load progress bar is visible.
Comment 3 Steve Randall 2021-01-28 14:27:04 UTC 
OK, looks like I lost my comments when I attached the patch.

Your suggestion works, but 25 pixels is barely visible. I increased to 120 (same as the main window progress bar) and that looks OK.

After my earlier attempt, I noticed that, if I hover over a link while loading is in progress, the link text would entirely squeeze out the bar. So a fixed size is necessary anyway, making expansion redundant.
Comment 4 Paul 2021-01-29 10:24:22 UTC 
fixed in git
Note You need to log in before you can comment on or make changes to this bug.