Bug 4425 - Fix opening links with external browser
Summary: Fix opening links with external browser
Status: CLOSED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins/Fancy (show other bugs)
Version: 4.0.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2020-12-17 02:51 UTC by Orivej Desh
Modified: 2020-12-27 20:13 UTC (History)
1 user (show)

See Also:


Attachments
Support opening links with external browser (1.92 KB, patch)
2020-12-17 02:51 UTC, Orivej Desh
Details | Diff
Support opening links with external browser (2.31 KB, patch)
2020-12-17 04:00 UTC, Orivej Desh
Details | Diff

Description Orivej Desh 2020-12-17 02:51:48 UTC
Created attachment 2158 [details]
Support opening links with external browser

# Patch description

Support opening links with external browser

viewer->cur_link was not being set since press_button_cb has been
disabled because webkit2gtk has dropped webkit_web_view_get_hit_test_result.

# Patch license

https://claws-mail.org/COPYING
Comment 1 Michael Rasmussen 2020-12-17 03:23:17 UTC
The patch does not apply using git am. Have you made the patch using git format-patch?
Comment 2 Michael Rasmussen 2020-12-17 03:36:30 UTC
Using git apply works. git format-patch preferred since then commit message is added automatically.
Comment 3 Michael Rasmussen 2020-12-17 03:58:34 UTC
This seems to work as intended.
Comment 4 Orivej Desh 2020-12-17 04:00:21 UTC
Created attachment 2160 [details]
Support opening links with external browser

(The same patch in git format-patch format.)
Comment 5 Michael Rasmussen 2020-12-18 01:49:12 UTC
(In reply to Orivej Desh from comment #4)
I had already used git apply but the reason for format-patch is that whatever you write in the message body will be applied as commit message not leaving it up to the committer to either copy/paste yours or come up with something them selfs;-)
Comment 6 Paul 2020-12-22 13:26:16 UTC
crashes here when right-clicking a link.
Comment 7 Michael Rasmussen 2020-12-27 20:11:49 UTC
(In reply to Paul from comment #6)
Fixed the crash and committed patch with this fix.

Note You need to log in before you can comment on or make changes to this bug.