Created attachment 2157 [details] Disable remote content by using a void proxy # Patch description Disable remote content by using a void proxy enable-dns-prefetching=0 has stopped blocking remote content after the switch to webkit2gtk. Disabling it with a false proxy works. Setting proxy to "" works well with libsoup-backed webkit2gtk since it prevents any connection attempts. If libcurl-backed webkit2gtk won't like it, it may be replaced by "http://127.0.0.9:9" (with 9 being reserved for the discard service, and 127.0.0.9 being more greppable than 127.0.0.1). # Patch license https://claws-mail.org/COPYING
The patch does not apply using git am. Have you made the patch using git format-patch?
Using git apply works. git format-patch preferred since then commit message is added automatically.
I have an email containing image references like below which is displayed even if loading of remote contents is disabled? http://i1.cmail20.com/ei/j/A9/DEC/162/234735/csfinal/cbs_logo_horizontal_2lines_blue_rgb2.png http://i1.cmail20.com/ei/j/A9/DEC/162/234735/csfinal/campaign-monitor_jul_2020-01-9900000000079e3c.png http://i9.cmail20.com/static/eb/master/13-the-blueprint-3/images/fblike-icon@2x.png http://i10.cmail20.com/static/eb/master/13-the-blueprint-3/images/tweet-icon@2x.png http://i2.cmail20.com/static/eb/master/13-the-blueprint-3/images/lishare-icon@2x.png http://i1.cmail20.com/static/eb/master/13-the-blueprint-3/images/forward-icon@2x.png https://sekretariatforledelseogkommunikation.cmail20.com/t/j-o-aidilll-ijutandr/o.gif Since this email does not contain any confidential I can forward it by request?
Created attachment 2159 [details] Disable remote content by using a void proxy Could you update the patch guidelines at https://claws-mail.org/devel.php ? I had to edit the output of git format-patch to make it apply with -p0.
Yes, please forward it to me.
Could you check if changing the first argument of webkit_network_proxy_settings_new from "" to "http://127.0.0.9:9" helps?
Another possibility is that the images were cached locally. Please disable remote content by default (if you've enabled it before), close claws-mail, delete ~/.cache/claws-mail/WebKitCache, then open the email with images.
I have forwarded the email in question to you as an attachment.
(In reply to Orivej Desh from comment #7) I deleted ~/.cache/claws-mail/WebKitCache and of course had disabled remote contents. I have also tried changing the proxy url as suggested, including disabling embedded javascript and images but to no avail. I will add a screendump of my settings. Cache content: ll ~/.cache/claws-mail/WebKitCache/Version\ 16/Blobs/ total 0
Created attachment 2161 [details] screendump of preference
it works for me, albeit with some warnings thrown.
pushed to git. thanks!