Created attachment 1999 [details] Patch to resolve issue On tiling WMs it does not show up as a modal but instead a maximised window. Included patch resolves the issue by making behaviour of prefs_display_header consistent with prefs_summary_column.
Which tiling WMs?
> Which tiling WMs? I use i3, but I imagine that the behaviour will be the same in similar WMs as well. In any case, the patch attached just makes the behaviour of the modal in question consistent with other preferences windows, which is correct as far as I can tell.
While I do not argue that having the dialogs behave in the same way is a good thing, I wonder if disabling resizeability is not a bit heavy-handed way to signal to the window manager that this is a dialog window. Alexander, can you please try this instead? gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG);
> Alexander, can you please try this instead? > gtk_window_set_type_hint(GTK_WINDOW(window), GDK_WINDOW_TYPE_HINT_DIALOG); I added that after gtk_window_set_resizable(GTK_WINDOW (window), TRUE); and it behaves as it should (as a modal/dialog window above the other parts of the UI), and it can still be resized. I agree that disabling the ability to resize the windows really is a bit heavy-handed - perhaps the others should have theirs re-enabled?
Yes, we will likely need to go over all of our dialog windows and assign these hints and fix resizability as needed. I'm a bit curious what this will do on Windows, too. :)