Bug 4214 - Rssyl does not remember deleted messages
Summary: Rssyl does not remember deleted messages
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (Windows)
Classification: Unclassified
Component: default (show other bugs)
Version: 3.17.3
Hardware: PC Windows 10
: P3 major
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2019-05-16 03:51 UTC by jbzdarkid
Modified: 2019-08-26 17:52 UTC (History)
1 user (show)

See Also:


Attachments
Repro steps, pictured (112.12 KB, image/png)
2019-05-16 03:51 UTC, jbzdarkid
Details

Description jbzdarkid 2019-05-16 03:51:11 UTC
Created attachment 1982 [details]
Repro steps, pictured

When I delete messages from rss feeds and then refresh, the messages come back immediately.
I'm not sure if I'm doing something wrong, or if my claws-mail is in a bad state somehow.
Comment 1 m 2019-08-12 15:51:16 UTC
I believe this works as intended. RSSyl will pull all messages currently active in the feed, which is usually the last 10 messages, 15 for Youtube.

If you have deleted them, it will pull them again. The way to handle these with RSSyl is to mark them as read, and select 'hide read messages'.

You may deselect 'keep old items' in Feed Properties so the messages that are no longer in the feed will eventually be deleted.
Comment 2 Andrej Kacian 2019-08-12 17:44:53 UTC
No, that's incorrect, we actually remember deleted messages (articles, items, whatever you prefer to call them), based on their title, ID and date published. On each refresh, item which matches all three is ignored completely. This information is kept in a file called ".deleted" in each feed's folder inside ~/.claws-mail/RSSyl.

The problem is that RSS format is so vaguely defined that almost anything is allowed and almost nothing is mandatory, so naturally while some sites have well-behaved feeds, others generate all kinds of ugly (yet still allowed by the format specification) feeds, where IDs are not always unique, publication date gets updated, titles change, etc...

In this particular case, however, I suspect something wrong with how Windows 10 handles the ".deleted" files, because the xkcd.com feed seems well-behaved in this regard on Linux - deleted items stay deleted after a refresh.

I will find the time to take a look at it in next few days, I hope.
Comment 3 Little Girl 2019-08-12 20:08:24 UTC
It seems to go beyond Windows to GNU/Linux. I'm seeing this issue, too, on a machine using Claws Mail v3.13.2 on a machine that runs Ubuntu MATE Xenial 16.04.6 LTS and when I visit some RSS feeds on a private server.

System Information:
	GTK+ 2.24.30 / GLib 2.48.2
	Locale: en_US.UTF-8 (charset: UTF-8)
	Operating System: Linux 4.15.0-55-generic (x86_64)
Comment 4 Andrej Kacian 2019-08-12 21:25:53 UTC
Interesting. Can you please post console output from "claws-mail --debug" from the moment of starting the feed refresh until it finishes?
Comment 5 Little Girl 2019-08-13 14:38:33 UTC
It looks like my issue was a user error rather than any failing on Claws Mail's part.

After reading through these bug report messages again, I went hunting through the settings to find the "Hide read messages" option that m mentioned in here and found the "Hide deleted messages" option right there with it. Putting a check in that box causes them to be marked for deletion during the current session and to vanish in the next session, which solves it for me.

Since that doesn't fully remove them from the feed, I also went looking for the "Keep old items" option in the feed properties that m had mentioned in here and didn't find it. Instead, I found "Remove older message bodies" inside of the "Synchronize for offline use" section in the feed properties. That should get rid of them, so everything is bug-free and working as intended for me.

Sorry for the noise, and I hope this helps.
Comment 6 Little Girl 2019-08-13 14:40:02 UTC
I should add that I found the "Hide deleted messages" and "Hide read messages" options in the View menu while the feed was selected.
Comment 7 Andrej Kacian 2019-08-26 17:52:34 UTC
This has now been fixed in git.

Note You need to log in before you can comment on or make changes to this bug.