Bug 4121 - Moving a subfolder in another folder erases its processing rules
Summary: Moving a subfolder in another folder erases its processing rules
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Filtering (show other bugs)
Version: 3.17.2
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2018-11-18 16:13 UTC by George
Modified: 2018-11-19 10:16 UTC (History)
0 users

See Also:


Attachments

Description George 2018-11-18 16:13:47 UTC
version 3.17.0git172

STR:

1. Have a folder structure like:

+ My Feeds (RSSyl)
++ Folder1
+++ Feed
++ Folder2

2. Right click "Feed" and create a processing rule for it

3. Move "Feed" in "Folder2"

4. Right click "Feed" to check processing rules

EXPECTED:

The rule created in step 2 should be there.

ACTUAL:

There are no rules.
Comment 1 users 2018-11-18 18:24:05 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-11-18 18:24:05.268296877 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=acf535ca86d1a52902646c6248f7446e10899df2
Author: Paul <paul@claws-mail.org>
Date:   Sun Nov 18 17:23:35 2018 +0000

    fix bug where creating a new folder wth inheriting properties doesn't write processinf rules
    
    after copying folder with 'inherit properties from parent folder' set,
    the processing rules are (initially) present in the processing rules
    dialogue, but are not actually written. So on a restart they are 'lost'.
    
    This is probably the actual bug 4121, ' Moving a subfolder in another
    folder erases  its processing rules', rather than the description given.
Comment 2 Paul 2018-11-18 19:12:09 UTC
(In reply to comment #1)
>     after copying folder with 'inherit properties from parent folder' set,

What i meant to say was 'when creating a new folder' rather than 'after copy folder'.

Moving this folder after creating it thus will not carry over the unsaved processing rules, which is probably what you meant to say.
Comment 3 George 2018-11-18 19:42:09 UTC
No, I didn't mean to say anything about copying or creating a folder but about moving it as this is what I did: I simply dragged and dropped it in another folder.

Anyway this commit seems to fix it.

Thanks :)
Comment 4 Paul 2018-11-18 19:50:36 UTC
I could not reproduce what you described, only what I fixed. My fix did not alter (for me) what you described.
Comment 5 George 2018-11-19 10:16:45 UTC
I see. Hm. I don't know if that changes the STR essentially but what I actually did initially was:

1. Have a folder structure like:

+ My Feeds (RSSyl)
++ Folder1 (no any processing rules)
+++ Feed (with some processing rules)

2. Create Folder2 and structure becomes

+ My Feeds (RSSyl)
++ Folder1
+++ Feed
++ Folder2

3. Drag'n'drop Feed into Folder2

And the result was: the processing rules for Feed were lost.

Note You need to log in before you can comment on or make changes to this bug.