Bug 3838 - Canceled right-click on message list leaves UI in inconsistent state
Summary: Canceled right-click on message list leaves UI in inconsistent state
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.15.1
Hardware: PC Linux
: P3 minor
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-06-22 14:20 CEST by Pierre Fortin
Modified: 2019-05-14 23:22 CEST (History)
0 users

See Also:


Attachments
return cursor (1.18 KB, patch)
2017-06-22 18:05 CEST, Andrej Kacian
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Fortin 2017-06-22 14:20:43 CEST
To reproduce:
- right-click on any message other than the one currently selected/displayed
- click anywhere BUT the menu

UI now shows previously selected message's content while the message right-clicked (RC) is "selected". If the previously selected message was new/unread, its status does not change.  Clicking on the previously selected message (content still displayed), the message selection changes back; but the status does not change from new/unread to read; another message must be selected, then back to this message for status to correctly display.

The obvious solution could require a lot of work; but I'd suggest simply changing the execution order to not 'select' the RC'ed message until after a RC action is selected -- if no action is selected; just ignore the RC, leaving the display as it was.
Comment 1 Andrej Kacian 2017-06-22 18:05:51 CEST
Created attachment 1762 [details]
return cursor

I disagree with the solution. When you're right-clicking a message in summaryview, you want to do something to it, and so it is good that the cursor is placed on it together with the menu popup - you can make sure that whatever you are about to do, you are doing to the correct message, IOW you did not misclick.

Instead, the cursor should probably return to its original position. Attached patch does that, but only in case a message is already displayed. If there is no message displayed (messageview is blank), the cursor stays where you right-clicked. Additional work is needed if we want to return the cursor to its original position even in that case (do we?).

This is just a quick patch, untested against different "open when selected..." configurations, but it shouldn't cause any issues.
Comment 2 Pierre Fortin 2017-06-22 22:48:53 CEST
My reason for the suggested solution was based on how this flaw was discovered...  I have a very sensitive mouse and a sometimes heavy middle finger that accidentally generates right-clicks.  So, in that case, just canceling the action and staying on the current message makes sense.  

Having opened this as a "minor" issue, I'm open to any solution.  :)
Comment 3 Andrej Kacian 2019-05-14 23:22:00 CEST
Patch applied in git, thanks for the report.