Indicator integration isn't good: First when I enabled i here: preferences-notification-Indicator-Add to indicator applet It worked good: Showed unread in messaging menu. And after I read all new indicator became grey as expected. But after receiving new messages indicator didn't get blue. Tried to enable "register claws-mail" option in preferences. And still no success.
Created attachment 1198 [details] ubuntu_12.10_indicator-messages In ubuntu 12.10 indicator-messages got updated, introducing a new libmessaging-menu api & deprecating the old libindicate library. I spent some time to rewrite the "indicator" part of the notification plugin and after a few days of test, i can claim that "it just works" and fixes this bug.
Could the patch please be merged, and the new plugin packaged on the Claws-Team PPA, and this bug closed? Thanks!
Any status on this? We're still carrying this as a delta in Ubuntu against the Debian package.
Mmmh, sorry, we somehow missed that. Thanks Sebastien for the patch! Were there any other libindicate users than old Unity?
*** Bug 2753 has been marked as a duplicate of this bug. ***
*** Bug 3178 has been marked as a duplicate of this bug. ***
From a quick glimpse of the patch and a quick search on packages.debian.org, seems there's no 'unity' library in debian unstable. So, if this is added upstream "as is" I would have to counter-patch upstream in the Debian package to remove it (or loss libindicate feature, but doesn't look like a good option when a simple patch can restore it... :) If you do the Ubuntu packages from the Debian ones, you would have to undo that counter-patch, so still carrying a delta, so not sure what is all worth for. As currently, it's an Ubuntu specific patch. To be more neutral and therefore more suitable for upstream the patch should be reworked to detect Ubuntu libs and conditionally compile that Ubuntu part and stay with libindicate if not available. Said that I'm an interested part, so feel free to disagree :)
Yeah, that was the goal of my question - I didn't know whether libindicate was already Ubuntu-specific. So yes, that patch could go in the tree if it is done as a separate sub-feature of the Notification plugin.
Also, thanks for the information that you have that in Ubuntu packages already. I have been trying to get this to run on my machine some time ago, but failed to set up the environment correctly. That other parties tested this, and it worked for them, is valueable information.
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2016-09-29 22:29:03.233577420 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=6a979ec3e137b75fc78dd3652e7758fb441adbca Merge: dd241d4 437668c Author: Colin Leroy <colin@colino.net> Date: Thu Sep 29 22:29:02 2016 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=437668c7f0207b6ea6f9c1467e15411a0903c8ca Author: Holger Berndt <berndth@gmx.de> Date: Thu Sep 29 22:21:02 2016 +0200 Notification plugin: Port from libindicate to unity/messaging menu This is a slightly modified version of the patch from Sebastien Noel, fixes bug #2665