Bug 3973 - 'select all' in summaryview does not automatically focus the summaryview
Summary: 'select all' in summaryview does not automatically focus the summaryview
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.16.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2018-02-24 19:31 UTC by George
Modified: 2018-02-25 14:19 UTC (History)
0 users

See Also:


Attachments

Description George 2018-02-24 19:31:46 UTC
Have 2 different folders containing at least a few same messages.

STR:
1. Click folder #1
2. Type some string to filter a few, e.g. From/To/Cc/Subject/Tag: abc@example.com
3. A few messages show up according to the filter
4. Switch to folder #2 - it contains at least a few of the same messages, so it shows messages in the list (filter is still active)
5. Press Ctrl+A - messages get selected
6. Try to drag the selected messages to folder #3

EXPECTED
Dragging should work

ACTUAL
Dragging does not work. The only way to make it work is (when in folder #2): deselect the messages (which were previously selected using Ctrl+A) then Ctrl+A again - then dragging works.
Comment 1 George 2018-02-24 19:37:46 UTC
Actually it seems unrelated to filters. Simply navigating to a folder and pressing Ctrl+A makes the selected messages non-draggable. (unless a mouse click previously occurred somewhere in the message list).

In Preferences:Display:Summaries:Open message when selected I have all checkboxes on except "Always" and "When opening a folder" and "Set default selection when entering a folder" is set to "none"
Comment 2 Paul 2018-02-24 21:09:41 UTC
Works for me. Tested several times.
Comment 3 George 2018-02-24 21:52:33 UTC
Aren't you using a later (git) version?
Comment 4 George 2018-02-24 22:05:13 UTC
Please make sure that when you click a mail folder nothing is automatically selected and that you don't click in the message list before pressing Ctrl+A.

I can reproduce it each and every time.
Comment 5 George 2018-02-24 22:05:34 UTC
KDE Plasma 5.8.7 in case that matters.
Comment 6 George 2018-02-24 22:09:30 UTC
I also notice that pressing "Delete" after Ctrl+A also has no effect whatsoever.
Comment 7 users 2018-02-25 14:19:04 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-02-25 14:19:03.915195538 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8acabfe3d70e1841ab9e838e62a8f55e76512112
Merge: b4a3b2d a3e48bd
Author: Colin Leroy <colin@colino.net>
Date:   Sun Feb 25 14:19:03 2018 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3
Author: Paul <paul@claws-mail.org>
Date:   Sun Feb 25 13:18:40 2018 +0000

    fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'
    
    The problem is apparent when 'default selection on entering a folder' is
    set to 'none' and the first user action on entering the folder is
    'select all'. This visually selected all the messages but summaryview
    did not have the focus, so any actions performed on that list would
    fail.
    
    Removed summary_select_all(), which didn't quite do as advertised and
    instead use gtk_cmclist_select_all() which selects and focuses.
Comment 8 users 2018-02-26 22:10:07 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-02-26 22:10:07.199515533 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=7b117b4d0e3ea5c025e35655dc51b00c8b1b8330
Merge: 400ed8b 6329dc3
Author: Colin Leroy <colin@colino.net>
Date:   Mon Feb 26 22:10:04 2018 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=6329dc382d539135add187c5b1e8cf6efe1a9d22
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Mon Feb 26 22:06:27 2018 +0100

    Fix summary_select_all when there is nothing selected.
    
    Due to how GtkCMCList works, we first need to focus and
    select a row.
    Fixes bug #3973, ''select all' in summaryview does not
    automatically focus the summaryview'

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9bac1080abb054f6d743cb5672a6d5d3fed5e6e0
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Mon Feb 26 22:06:02 2018 +0100

    Revert "fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'"
    
    This reverts commit a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3.
    That commit introduced slowness when selecting all rows.
Comment 9 users 2018-02-26 22:10:08 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-02-26 22:10:07.199515533 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=7b117b4d0e3ea5c025e35655dc51b00c8b1b8330
Merge: 400ed8b 6329dc3
Author: Colin Leroy <colin@colino.net>
Date:   Mon Feb 26 22:10:04 2018 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=6329dc382d539135add187c5b1e8cf6efe1a9d22
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Mon Feb 26 22:06:27 2018 +0100

    Fix summary_select_all when there is nothing selected.
    
    Due to how GtkCMCList works, we first need to focus and
    select a row.
    Fixes bug #3973, ''select all' in summaryview does not
    automatically focus the summaryview'

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9bac1080abb054f6d743cb5672a6d5d3fed5e6e0
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Mon Feb 26 22:06:02 2018 +0100

    Revert "fix bug 3973, ''select all' in summaryview does not automatically focus the summaryview'"
    
    This reverts commit a3e48bd6e7e62dedfef8ddedbeeb90400b5234b3.
    That commit introduced slowness when selecting all rows.

Note You need to log in before you can comment on or make changes to this bug.