Bug 3935 - Build from GIT master broken on arch linux
Summary: Build from GIT master broken on arch linux
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.16.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-12-12 02:37 UTC by glitsj16
Modified: 2017-12-12 18:32 UTC (History)
0 users

See Also:


Attachments
Probable fix (1.05 KB, patch)
2017-12-12 13:44 UTC, Ricardo Mones
no flags Details | Diff

Description glitsj16 2017-12-12 02:37:26 UTC
Looks like LDAP-related commit http://git.claws-mail.org/?p=claws.git;a=commit;h=48f72c22f91fbe0d6e872e89bd4dce9d39090e81 breaks the claws-mail build from GIT master on arch linux:
[...]
compose.c: In function ‘_ldap_srv_func’:
compose.c:7100:2: error: unknown type name ‘LdapServer’; did you mean ‘GDBusServer’?
  LdapServer *server = (LdapServer *)data;
  ^~~~~~~~~~
  GDBusServer
compose.c:7100:24: error: ‘LdapServer’ undeclared (first use in this function); did you mean ‘server’?
  LdapServer *server = (LdapServer *)data;
                        ^~~~~~~~~~
                        server
compose.c:7100:24: note: each undeclared identifier is reported only once for each function it appears in
compose.c:7100:36: error: expected expression before ‘)’ token
  LdapServer *server = (LdapServer *)data;
                                    ^
compose.c:7103:86: error: request for member ‘control’ in something not a structure or union
  debug_print("%s server '%s'\n", (*enable == TRUE ? "enabling" : "disabling"), server->control->hostName);
                                                                                      ^~
compose.c:7104:8: error: request for member ‘searchFlag’ in something not a structure or union
  server->searchFlag = *enable;
        ^~
compose.c: In function ‘compose_destroy’:
compose.c:9102:25: error: ‘Compose {aka struct _Compose}’ has no member named ‘passworded_ldap_servers’
  g_slist_foreach(compose->passworded_ldap_servers,
                         ^~
compose.c:9104:22: error: ‘Compose {aka struct _Compose}’ has no member named ‘passworded_ldap_servers’
  g_slist_free(compose->passworded_ldap_servers);
                      ^~
make[4]: *** [Makefile:1492: compose.o] Error 1
make[4]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/claws/src'
make[3]: *** [Makefile:1552: all-recursive] Error 1
make[3]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/claws/src'
make[2]: *** [Makefile:1241: all] Error 2
make[2]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/claws/src'
make[1]: *** [Makefile:775: all-recursive] Error 1
make[1]: Leaving directory '/home/glitsj16/.buildzone/00.tmpfs/claws'
make: *** [Makefile:550: all] Error 2

Full log at https://ptpb.pw/rx0v.debug
When reverting the aforementioned commit the build goes fine.

Regards
Comment 1 Ricardo Mones 2017-12-12 13:44:21 UTC
Created attachment 1824 [details]
Probable fix

Hi, can you check if the attached patch fixes it for you?

Thanks,
Comment 2 glitsj16 2017-12-12 14:24:23 UTC
@Ricardo:

 Hi, confirming the attached patch does fix things. Really appreciate your speedy reply and solution. Many thanks and all the best.

Regards
Comment 3 users 2017-12-12 18:30:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-12-12 18:30:02.806534479 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d7c2b57323c923e9c493180f11c2a7e25604309c
Merge: 4e2f656 5b7108e
Author: Colin Leroy <colin@colino.net>
Date:   Tue Dec 12 18:30:02 2017 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=5b7108e97efe38ce7888b3af90a302e32c01c91e
Author: Ricardo Mones <ricardo@mones.org>
Date:   Tue Dec 12 18:27:23 2017 +0100

    Fix bug 3935: build from GIT master broken on arch linux
    
    Completes 48f72c22f91fbe0d6e872e89bd4dce9d39090e81 to allow building
    with disabled LDAP support.
Comment 4 Ricardo Mones 2017-12-12 18:32:21 UTC
You're welcome! Thanks for the feedback.

Note You need to log in before you can comment on or make changes to this bug.