Bug 3866 - slibtool causes compile failure (patch attached)
Summary: slibtool causes compile failure (patch attached)
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.15.1
Hardware: PC Linux
: P3 major
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-08-14 03:36 UTC by Robby Workman
Modified: 2017-08-26 12:03 UTC (History)
0 users

See Also:


Attachments
fix build failures with slibtool (2.27 KB, patch)
2017-08-14 03:36 UTC, Robby Workman
no flags Details | Diff

Description Robby Workman 2017-08-14 03:36:56 UTC
Created attachment 1777 [details]
fix build failures with slibtool

The following description comes from one of our users whose email address never received a confirmation mail from the bugzilla system, so I'm filing this bug on his behalf. The attached patch should fix the problem in git master - please ensure attribution goes to the patch author (that info is in the patch itself) rather than to me. Quoted text from user follows:


With the recent addition of slibtool to SBo I found that claws-mail did
not compile with it. After some investigation with the help of the
slibtool upstream it was discovered there are two bugs in the claws-mail
configure.ac. The more permissive libtool in Slackware swallows these
errors while slibtool will result in a build error.

In short the issues are:

1. The configure script contains ARCHIVE_LIBS=ARCHIVE_CFLAGS while
ARCHIVE_CFLAGS is not a variable nor does it exist.

2. There is a potentially bad sed that will try to remove -lc, but
instead it finds -lcrypt and then gives 'rypt' to gcc which is not a
correct build flag.
Comment 1 users 2017-08-26 10:05:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-08-26 10:05:02.859583185 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9f44613d2b82e9529b9ab41d551b81f12ba7ff1c
Merge: 3550790 404c674
Author: Colin Leroy <colin@colino.net>
Date:   Sat Aug 26 10:05:02 2017 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=404c674753092fe8e06f0a27da7405b30c646058
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sat Aug 26 10:03:51 2017 +0200

    Fix typo around libarchive in configure.ac.
    
    Patch by Orbea, Bug 3866 - slibtool causes compile failure

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8b55e4f97093aa19ea4ce4b868009e37c0293135
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sat Aug 26 10:00:07 2017 +0200

    Fixed incorrect PERL_LDFLAGS modification with sed.
    
    Patch by Orbea, Bug 3866 - slibtool causes compile failure
Comment 2 users 2017-08-26 10:05:04 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-08-26 10:05:02.859583185 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9f44613d2b82e9529b9ab41d551b81f12ba7ff1c
Merge: 3550790 404c674
Author: Colin Leroy <colin@colino.net>
Date:   Sat Aug 26 10:05:02 2017 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=404c674753092fe8e06f0a27da7405b30c646058
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sat Aug 26 10:03:51 2017 +0200

    Fix typo around libarchive in configure.ac.
    
    Patch by Orbea, Bug 3866 - slibtool causes compile failure

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8b55e4f97093aa19ea4ce4b868009e37c0293135
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sat Aug 26 10:00:07 2017 +0200

    Fixed incorrect PERL_LDFLAGS modification with sed.
    
    Patch by Orbea, Bug 3866 - slibtool causes compile failure
Comment 3 Andrej Kacian 2017-08-26 12:03:28 UTC
Applied in git, thanks!

Note You need to log in before you can comment on or make changes to this bug.