Bug 3828 - "Re-edit" should not recycle the Message-ID header
Summary: "Re-edit" should not recycle the Message-ID header
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.14.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-05-30 10:29 UTC by Tristan Miller
Modified: 2017-05-31 21:12 UTC (History)
0 users

See Also:


Attachments

Description Tristan Miller 2017-05-30 10:29:24 UTC
The Message->Re-edit command allows the user to open a new copy of a sent message so that it can be edited and sent again.  The copy preserves the headers from the original message, which is generally a good thing.  But one header it should *not* preserve is the Message-ID field, as this violates the uniqueness requirements of RFC 2392, RFC 5322, etc., and in turn can interfere with the storage, retrieval, and presentation of messages in mail clients and other mail processing software.

For example, in Thread View, Claws Mail itself gets confused by duplicate Message-IDs, anchoring the reply tree at only one of the messages.  (This is particularly noticeable when using "Re-edit" to send messages to a mailing list that you subscribe to.)  More seriously, having substantially different messages with duplicate Message-IDs can lead to data loss when running Claws Mail's duplicate filter, which checks only the Message-ID header and not the message content.

Steps to reproduce:
1. Navigate to a "Sent" folder and select a message.
2. Message->Re-edit
3. Edit the message content and/or headers
4. Message->Send
5. Using View->"Show All Headers" or View->"Message Source", examine the "Message-ID" header of the original and "re-edited" messages.

Observed behaviour:
6. The Message-IDs are the same.

Expected behaviour:

6. The Message-ID for the "re-edited" message should be different.
Comment 1 users 2017-05-31 21:12:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-05-31 21:12:02.514475828 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b32c20402ffcd23ebb24b2f264477978d5292c77
Merge: 45cbd9a d661fd7
Author: Colin Leroy <colin@colino.net>
Date:   Wed May 31 21:12:02 2017 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d661fd7233e971a190b54ef3fa1dac1861f44833
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Wed May 31 21:10:19 2017 +0200

    Only preserve existing Message-ID when reediting a draft.
    
    This is a followup to commit e22cbed1f.
    Closes Bug 3828 - "Re-edit" should not recycle the Message-ID header
Comment 2 Andrej Kacian 2017-05-31 21:12:16 UTC
You're right, this is an unwanted side-effect of a commit made few months ago. Fixed now in git.

Note You need to log in before you can comment on or make changes to this bug.