Bug 3797 - Unfold quoting renders quotes completely confusing
Summary: Unfold quoting renders quotes completely confusing
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message View (show other bugs)
Version: 3.15.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-03-29 13:15 UTC by Ralf Mardorf
Modified: 2017-03-30 10:22 UTC (History)
0 users

See Also:


Attachments

Description Ralf Mardorf 2017-03-29 13:15:01 UTC
Hi,

the new unfold quoting renders quotes completely confusing.

Claws 3.15.0-3-g8819fe

I don't know what this commit actually tries to fix, since 3.15.0-1-g978206 was without an issue, here the commit just introduces a bug.

It looks like this:

On Wed, 29 Mar 2017 12:15:19 +0200, A wrote:
>On Wed, 29 Mar 2017 13:09:02 +1030, B:
  >>Hello A,
>>how are you?
] >  
>
>Hello B,
>I'm fine.
.]

This is disgusting!

Regards,
Ralf
Comment 1 users 2017-03-30 01:10:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-03-30 01:10:03.331213234 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=08d63004f67b56f8a36a717e07b42edfc4c28747
Merge: ad37411 1acb353
Author: Colin Leroy <colin@colino.net>
Date:   Thu Mar 30 01:10:02 2017 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1acb353987cb2a45b6b6802cc48db6f66aac3121
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Mar 30 01:04:22 2017 +0200

    Fix the other off-by-one bug in textview quoting.
    
    There were two complementary off-by-one bugs, each masking
    the other one. Commit 8819fe fixed the first one, thus
    unmasking this one.
    
    This should also fix the disgusting bug #3797:
    "Unfold quoting renders quotes completely confusing".
Comment 2 Ralf Mardorf 2017-03-30 09:50:34 UTC
Thank you,

fixed with 3.15.0-8-g95ca860 as well as another issue I noticed for
3.15.0-3-g8819fe, clicking links in the signature works again, too.

Regards,
Ralf
Comment 3 Andrej Kacian 2017-03-30 10:22:39 UTC
I'm glad it's no longer disgusting.

I was trying to fix a bug which is mostly hidden most of the time, but fixing it uncovered some more flaws that would take more effort to fix than I can currently spare, so I ended up reverting my changes.

A personal observation, if I may: if finding bugs in a development snapshot of an application disgusts you, you should probably stay away from development snapshots, for your own well-being.

Note You need to log in before you can comment on or make changes to this bug.