Bug 3354 - Event cancellation uses incorrect method parameter for Content-Type header
Summary: Event cancellation uses incorrect method parameter for Content-Type header
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/vCalendar (show other bugs)
Version: 3.11.1
Hardware: All Linux
: P3 normal
Assignee: users
URL: https://bugs.debian.org/773487
Depends on:
Blocks:
 
Reported: 2014-12-19 16:21 UTC by Ricardo Mones
Modified: 2015-01-15 23:18 UTC (History)
0 users

See Also:


Attachments

Description Ricardo Mones 2014-12-19 16:21:03 UTC
Quoting original submitter:
----------
I have been experimenting with Claws Mail for calendaring and found that when
cancelling events as an organiser, Claws (or rather the vCalendar plugin)
sends a mail with an inappropriate Content-Type parameter for the scheduling
method.

According to RFC 6047 (iMIP)...

"The [RFC2045] "Content-Type" header field MUST also include the MIME
parameter "method".  The value MUST be the same (ignoring case) as the value
of the "METHOD" property within the iCalendar object."

http://tools.ietf.org/html/rfc6047#section-2.4

However, in a cancellation object, METHOD will be CANCEL, and thus the
Content-Type must also employ a method parameter with the value "CANCEL".
Instead, Claws' vCalendar plugin seems to use "REQUEST".

The upstream code that is probably responsible for this is here:

http://git.claws-mail.org/?p=claws.git;a=blob;f=src/plugins/vcalendar/vcal_manager.c;h=a21c6a859f888fa3f8950e381dc4f9122e9903f3;hb=HEAD#l1238

Here is what is produced:

Content-Type: text/calendar; method=REQUEST; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Message-ID: <20141218231403.3f080abd.paul.boddie@example.com>

BEGIN:VCALENDAR
VERSION
 :2.0
PRODID
 :-//Claws Mail//NONSGML Claws Mail Calendar//EN
CALSCALE
 :GREGORIAN
METHOD
 :CANCEL

Note the mismatch between the Content-Type method value and the iCalendar
METHOD property.
----------

Thanks in advance,
Comment 1 users 2014-12-19 16:30:03 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-12-19 16:30:03.030271179 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b3952be7e999e2cef193d16c526d6947d61f4c25
Merge: cb2051d b018455
Author: Colin Leroy <colin@colino.net>
Date:   Fri Dec 19 16:30:02 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b018455356c552441128c1004be4633b9947ff7a
Author: Colin Leroy <colin@colino.net>
Date:   Fri Dec 19 16:26:37 2014 +0100

    Fix bug #3354, "Event cancellation uses incorrect method parameter for Content-Type header"

Note You need to log in before you can comment on or make changes to this bug.