Bug 3249 - Subtle keyboard UI problems involving the Go To Folder dialog
Summary: Subtle keyboard UI problems involving the Go To Folder dialog
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Folder List (show other bugs)
Version: 3.10.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-08-16 18:32 UTC by nobrowser
Modified: 2014-08-20 13:04 UTC (History)
1 user (show)

See Also:


Attachments
Set focus on row after it is expanded and visible (1.08 KB, patch)
2014-08-19 20:56 UTC, Andrej Kacian
no flags Details | Diff

Description nobrowser 2014-08-16 18:32:54 UTC
Please read carefully, I think _all_ the ingredients I list here are
needed to reproduce this bug.

I start with my folder list collapsed, ie. only top level folders are
shown.  (In my server's IMAP implementation top level folders are
siblings of INBOX, not its children.)  I open one of the top level
folders (INBOX should do) and interact with it, reading some messages
and switching among messages with the Up and Down keys.  Then I decide
to open another folder, but one that is nested 1 level deep and
therefore not displayed in the folder list.  To that end I hit the "Go
To Other Folder" key combo (Ctrl-G for me).  I select and open the
desired folder.  Claws has helpfully expanded the folder list so that
the newly opened folder is now visible and highlighted in the list.
Again I interact with the folder and its messages, using Up and Down.

Finally I hit the Left key, giving focus to the folder list (or so I
hope - the visual focus representation in Claws is so weak that I can't
say for sure, but the folder list seems to react to keystrokes in
general).  And I have arrived in bug land: the Up and Down keys do not
work.  The Up key does nothing at all, and the Down key highlights the
topmost line in the list, ie. the account line.

I think I know what is happening here:  the folder list keeps state
including the highlighted line but this state is not updated correctly
when a parent folder is expanded as a side effect of selecting one of
its children in the Go To dialog.
Comment 1 Andrej Kacian 2014-08-19 20:56:16 UTC
Created attachment 1425 [details]
Set focus on row after it is expanded and visible

Looks like it only happens when the folder we are switching to is not initially visible in folderview, and its parents have to be expanded to show it. By looking at the code, we are setting focus row before expanding the parents, which explains why the folder does not really get focus in this case.

Attached simple patch fixes the issue for me.
Comment 2 nobrowser 2014-08-20 08:03:25 UTC
Confirmed that the patch fixes the problem for me.
Comment 3 Andrej Kacian 2014-08-20 13:04:30 UTC
Patch has now been committed and the fix will appear in next release. Thanks for the report!

Note You need to log in before you can comment on or make changes to this bug.