Bug 3094 - OK or Yes to create new directory?
Summary: OK or Yes to create new directory?
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Translations (show other bugs)
Version: 3.9.3
Hardware: All All
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-02-18 14:49 UTC by khazarian
Modified: 2014-04-21 10:48 UTC (History)
0 users

See Also:


Attachments

Description khazarian 2014-02-18 14:49:05 UTC
String:
HTML Output Directory '%s'\n
does not exist. OK to create new directory?

Buttons:
Yes/No.

Please rename string.  Please see suggestions below:

HTML Output Directory '%s'\n
does not exist. Press Yes to create new directory.

HTML Output Directory '%s'\n
does not exist. Create new directory?

HTML Output Directory '%s'\n
does not exist. Do you want to create new directory?

HTML Output Directory '%s'\n
does not exist. Would you like to create new directory?
Comment 1 Ricardo Mones 2014-02-18 15:50:19 UTC
I don't think is a mistake to answer yes or no to a “(It is) OK to do something?” question. Said that, English is not my native language and I may be wrong.

Anyway since the string has other problems lets use this bug for improving it.
Comment 2 Holger Berndt 2014-02-19 00:38:42 UTC
Personally, I like neither ok/cancel nor yes/no dialogs. You have to read too carefully what the question is - it might be forward or reverse logic. I like it better if the buttons themselves contain the action word, in this case for example "cancel" and "create". That makes it much harder to get the logic mixed up.
Comment 3 khazarian 2014-03-04 10:42:59 UTC
English is not my native language, too.  Isn't the word "OK" a slang word?

I think the idea of Holger Berndt is a good idea.
Comment 4 Paul 2014-03-04 11:02:58 UTC
(As a native English speaker) I find this bug report highly pedantic. Although not strictly correct, the labels are perfectly understandable. I agree that the label could (and should, even) be improved but the suggestions also have their shortcomings.

Personally, I like Yes or No buttons and do not agree with Holger.
Comment 5 users 2014-04-13 11:29:05 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-04-13 11:29:03.487553513 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f0ba39a7ecb81911fcb1d51bee75ca58e8fdf616
Merge: ef42e8c 308f993
Author: Colin Leroy <colin@colino.net>
Date:   Sun Apr 13 11:29:02 2014 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=308f9937247ca6ca0dc2ef554080705976a93a95
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sat Apr 12 14:14:09 2014 +0200

    Fix bug #3138 “pgpinline crashes on signature check if gppme fails to init”

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=864fd8e5fe8be79f565c9234ceb1ac3d43054309
Author: Ricardo Mones <ricardo@mones.org>
Date:   Sat Apr 12 13:25:18 2014 +0200

    Fix bug #3094 “OK or Yes to create new directory?”

Note You need to log in before you can comment on or make changes to this bug.