When the Enter key in the message list, the message is displayed in the Message View, even if this view was disabled. The desired and expected outcome, instead, was that pressing the Enter key opens a new window with the relevant message. It should also be ensured that the Message View once disabled stays disabled.
I was surpised that this bug was changed from 'bug' to 'enhancement'. I am not familiar with your classification scheme, but I wish to point out that this is indeed a bug: if I turn off the Message View, and it turns itself back on, as it currently happes, there is no doubt that this is a bug.
The point is that it doesn't turn itself back on - pressing the Enter key opens the message view. What you ask for is a different behaviour when pressing the Enter key, you don't want pressing the Enter key to open the message view, you want it to do what double-clicking the message and '/View/Open in new window' does. So that's a feature request.
I see. Is there a way to change the behaviour of the Enter key? I am not requesting that it should be changed by default. I would be equally fine if I could change it manually, as long as the issue is solved.
Created attachment 1338 [details] Patch to change behavior of Enter key in summaryview We have discussed this on IRC with Paul, and although we came to a conclusion that this should be controlled by a preference option, after looking at the code, I now have a different opinion. What I propose is: If messageview is visible (controlled by V key by default), Enter should display selected message in it. If messageview is not visible, Enter should leave it hidden, and open selected message in a new window. My reasoning is that this aligns better with the whole idea of a hidden messageview, just like the reporter says. On the other hand, this will change currently expected behavior. The currently expected behavior is buggy, in my opinion. The patch which does this is attached, it should be no problem to extend it with a new preference option, but I think it is unnecessary.
Hi, I was looking at that patch and it seemed good at first. But, I do have issues with this disabled-messageview thing. We do have a Summaries preference named "Open message when selected": "Always", "Never", "When messageview's visible". But this preference applies to summay row selection using up, down, pageup, pagedown, home and end. It also applies to entering a folder, or changing the summaryview list somehow (quicksearch etc). The rest of the navigation - Enter key, as this bug states - but also the whole View/Go to/ submenu ("prev/next unread message") which can be keyboard-navigated using shift-N, shift-P, etc, does reopen the hidden messageview. Also, Go to/Next and Go to/Prev don't follow that preference. I see no point in changing the behaviour for Enter, but not the View/Go to menu. The problem is that we can't fix it and keep the existing behaviour for people using a hidden messageview often. I suggest either changing nothing or fixing the whole thing.
I don't mean to be rude but... is it really so difficult to make <Enter> open the message in a new window? That's all I am asking for. Andrej has already contributed a patch. What's the point of beating about the bush now? Come on!
The point is that as maintainer, I'm unkeen on adding kludge over kludge on this kludgy area and I'd rather see it properly fixed. Nothing stops you from applying Andrej's patch or better, help us and contribute a full patch making this part of our code more sane. In the meantime, if nobody's interested in doing that work, well, we won't fire them :)
I would gladly contrubute to it, but I am a mere user, not a programmer. I really hope someone does something about this...