Bug 3026 - replace short by long IDs in dialogue(s) of gpg related plugin(s)
Summary: replace short by long IDs in dialogue(s) of gpg related plugin(s)
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/Privacy/PGP (show other bugs)
Version: 3.8.0
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-11-01 15:43 UTC by kardan
Modified: 2013-11-03 10:13 UTC (History)
0 users

See Also:


Attachments
dialogue listing keys with short IDs and without fingerprint (65.24 KB, image/png)
2013-11-01 19:25 UTC, kardan
no flags Details

Description kardan 2013-11-01 15:43:15 UTC
Hey,
when there are multiple keys for an address, I see a window showing the
keys with short IDs. I heard [1] these are deprecated. Please update
the dialogue accordingly.
Thousand thanks!
[1] http://www.asheesh.org/note/debian/short-key-ids-are-bad-news

<debug>
currently I cannot check it with latest git because it FTBFS:

In file included from gtkaspell.c:60:0:
./../gtk/gtkutils.h:214:0: warning: "GTK_TYPE_VBOX" redefined [enabled by default]
/usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:36:0: note: this is the location of the previous definition
./../gtk/gtkutils.h:220:0: warning: "GTK_TYPE_HBOX" redefined [enabled by default]
/usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:38:0: note: this is the location of the previous definition
gtkaspell.c: In function 'replace_word_cb':
gtkaspell.c:1220:28: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c: In function 'add_word_to_session_cb':
gtkaspell.c:1341:28: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c: In function 'add_word_to_personal_cb':
gtkaspell.c:1356:28: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c: In function 'check_with_alternate_cb':
gtkaspell.c:1365:28: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c: In function 'replace_with_create_dialog_cb':
gtkaspell.c:1436:38: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c:1438:28: error: 'GtkWidget' has no member named 'parent'
gtkaspell.c:1450:23: error: 'GtkDialog' has no member named 'vbox'
gtkaspell.c:1454:22: error: 'GtkDialog' has no member named 'vbox'
gtkaspell.c:1482:10: error: 'GtkWidget' has no member named 'style'
gtkaspell.c:1515:19: error: 'GtkDialog' has no member named 'action_area'
gtkaspell.c: In function 'set_menu_pos':
gtkaspell.c:2094:54: error: 'GtkWidget' has no member named 'window'
gtkaspell.c:2099:2: warning: 'gtk_widget_get_child_requisition' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkwidget.h:502): Use 'gtk_widget_get_preferred_size' instead [-Wdeprecated-declarations]
make[5]: *** [gtkaspell.lo] Error 1
</debug>
Comment 1 Paul 2013-11-01 15:48:41 UTC
Short IDs are not deprecated.
The window shows the long ID and it also shows the fingerprint.

For your build problems, don't use --disable-deprecated and/or --enable-gtk3.
Comment 2 kardan 2013-11-01 19:25:36 UTC
Created attachment 1307 [details]
dialogue listing keys with short IDs and without fingerprint

I see this dialogue with PGP/Inline plugin when there are multiple keys for one address. The IDs are short without fingerprint.
Comment 3 Paul 2013-11-01 19:50:42 UTC
oh. I thought you meant when verifying a signature. re-opened and marked as enhancement.
Comment 4 users 2013-11-02 08:45:07 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=53be0f54d38949688a7e54e44d2eebce95dc6acd
Merge: de88ea3 ec95243
Author: Colin Leroy <colin@colino.net>
Date:   Sat Nov 2 08:45:04 2013 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=ec952436361925077850223398627d52de59f76f
Author: Paul <paul@claws-mail.org>
Date:   Sat Nov 2 07:44:09 2013 +0000

    implement enhancement bug 3026, 'replace short by long IDs in dialogue(s) of gpg related plugin(s)'

Note You need to log in before you can comment on or make changes to this bug.