when deleting an open message , either by pressing "canc" on the keyboard or clicking the trash button, causes the message view to get blank. It should instead close it.
Not a good idea, IMHO. Currently, after it goes blank, you can press the next button and see the next message. If you close it you're back in the message list, and have to search again the next mail by hand to double click it and reopen the window.
Just a note, this is implemented in CVS: 2012-02-02 [pawel] 3.8.0cvs21 * src/folder.c * src/messageview.c * src/messageview.h * src/procmsg.h Fix bug #2501 'opened message blanks when moved to other folder' Detect message move and update message window contents accordingly, if message is moved to trash close window Mones: I think leaving blank windows is confusing to the user, is my message deleted? or claws-mail failed to do so? etc Also closing window follows "natural order of things", when you dispose things in RL you want them out of your sight. Surely we can do better here then blank window. I`m open for suggestions
Well, if it's confusing (since when no error message is an error? :-P) put a message in the blank window stating the message is deleted, but don't force me to find the next unread message in the message list _again_ breaking my workflow of inspection/deletion.
mones +1
After giving myself some time for thought.. I think we should display next message in message list upon deletion. This make a lot more sense to me then blank window with bad title and busy cursor. When there are no more messages in current folder display short info about no more messages in folder. Checking with competition they are doing something similiar. I'm not sure if this is good for trash folders too, still thinking about it. What do you guys think?
But we must not forget obey the settings.. according to them, we might not have to auto-open a message when another one is selected (if "open message when selected" is "never" for instance). BTW, I wonder how the OT was referring to the message view, or to possibly opened separate message windows?
I would request the developers to dumb things down to the user's thought process. We don't understand views, etc. What we do understand is this: 1. If I don't have a message view open, if I double-click on a message, it opens up in a pop-up window. 2. The pop-up window *is* the message. #2 above is where your thinking as a developer becomes a problem. You guys think the pop-up window is a view displaying the message that was double-clicked, and hitting the keyboard accelerator to display the next message in the same window is 'OK'. It's not. As a user, if I delete a message, I expect it to disappear from view, along with any windows it created. Now, workflow wise, you might be accustomed to browsing around in the message view and destroying windows on deletion will definitely be a problem. But call it semantics if you will, that "detached" message view should not be created by double-clicking a message. It's confusing to a 'normal' user. I'll put it differently to explain the hairline difference here. ONE. When the message view is in the main CM window. Users understand it displays the message selected. You delete the message, the view either displays the next selected message or goes blank. Expected behaviour. TWO. When you double-click a message and open the message in a new window. For a normal user, that's not a "detached" message view. That's a message, opened up separately, in a window of its own. Message deleted should mean window going away because the message does not exist. This is reinforced by the fact that yuo can double-click multiple messages to open each in a different window. In a "detached" message view, the window would only display the selected message, in a window of its own. Killing double-clicked message-windows on message deletion is expected behaviour. Killing "detached" message view on message deletion should not destroy the "detached" message view. I hope I've been able to explain the difference and the developers will keep CM the intuitive and easy-to-use MUA we know it to be.
Two clarifications/corrections to what I wrote above: 1. I know double-clicking a message to create a window for that message does not depend on the state of "message view" in the main CM window. 2. When I wrote "Killing "detached" message view on message deletion should not destroy the "detached" message view." I meant, "Deleting message should not destroy the "detached" message view. It should behave as the normal message view inside main CM window."
Pawel, agreed on showing next message, but only if user preferences say so, as wwp noted. Otherwise the "This message has been deleted" (or similar) in the window still applies.
Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.claws-mail.org/tracker/ 2012-03-14 [pawel] 3.8.0cvs32 * src/folder.c * src/messageview.c * src/messageview.h * src/procmsg.h * src/summaryview.c * src/textview.c * src/textview.h Better fix for bug #2501 Instead of leaving blank window after message move or delete, update separate view to next message in message list or display info why view is blank. This was discussed in bug #2621 comments.