Bug 2601 - "if item changes... never mark as unread" marks new items as read
Summary: "if item changes... never mark as unread" marks new items as read
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/RSSyl (show other bugs)
Version: other
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2012-02-12 04:05 UTC by Ryan Hill
Modified: 2015-05-21 23:36 UTC (History)
0 users

See Also:


Attachments
Proposed fix (631 bytes, patch)
2015-05-18 21:51 UTC, Nick Koretsky
no flags Details | Diff

Description Ryan Hill 2012-02-12 04:05:58 UTC
After switching several of my feeds to never mark message changes as unread I noticed that these feeds seemed to stop updating.  It turned out that any new items were being automatically marked as read, and since I hide read items they were never appearing in the message list.  Switching them back to either of the other two options behaves as expected.

I'm using version 0.32 of the RSSyL plugin.
Comment 1 Nick Koretsky 2015-05-18 21:51:12 UTC
Created attachment 1508 [details]
Proposed fix

Surprisingly this simple bug was not fixed since 2012 and still present in current version (3.11.1). Attached is proposed patch to fix this.
Comment 2 users 2015-05-21 23:35:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2015-05-21 23:35:02.493850152 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d08aee4b06208ba672c7f405869241a603fb524f
Merge: daf6b9d e0aa60c
Author: Colin Leroy <colin@colino.net>
Date:   Thu May 21 23:35:02 2015 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e0aa60ca7ac4d26fe0dd4b00cad59a0e770bb009
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu May 21 23:32:00 2015 +0200

    RSSyl: Leave unread flag on new items regardless of silent_update setting.
    
    Closes bug #2601
Comment 3 Andrej Kacian 2015-05-21 23:36:44 UTC
Hm, good catch, I have to admit that this bug completely slipped my radar. Anyway, the unread+new flag removal should never happen on a newly added item in any case. The committed fix[1] is a bit different, but essentially the same logic as in your patch. Thanks!

1. http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e0aa60ca7ac4d26fe0dd4b00cad59a0e770bb009

Note You need to log in before you can comment on or make changes to this bug.