Bug 2392 - support libnotify 0.7 and higher
Summary: support libnotify 0.7 and higher
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Plugins/Notification (show other bugs)
Version: 3.7.8
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2011-04-01 22:01 UTC by detrito
Modified: 2011-06-03 00:56 UTC (History)
1 user (show)

See Also:

Attachments
Patch to build with libnotify 0.7 (1.39 KB, patch)
2011-04-10 19:16 UTC, Christian Faulhammer 		no flags Details | Diff
modify value of LIBNOTIFY_TOO_HIGH (364 bytes, patch)
2011-04-13 17:06 UTC, detrito 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description detrito 2011-04-01 22:01:03 UTC 
claws-mail notification_plugin-0.26 (the same with the last CVS snapshot) does not compile anymore. when building it exits with:

witlibtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../gtkhotkey -pthread -I/usr/include/enchant -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/claws-mail -I/usr/include/claws-mail/common -I/usr/include/claws-mail/gtk -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -DLOCALEDIR=\"/usr/share/locale\" -pthread -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libpng14 -D_REENTRANT -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -march=i686 -mtune=generic -O2 -pipe -Wno-unused-function -Wall -Wall -MT notification_plugin_la-notification_popup.lo -MD -MP -MF .deps/notification_plugin_la-notification_popup.Tpo -c notification_popup.c  -fPIC -DPIC -o .libs/notification_plugin_la-notification_popup.o
notification_popup.c: In function ‘notification_libnotify_create’:
notification_popup.c:342:3: error: too many arguments to function ‘notify_notification_new’
/usr/include/libnotify/notification.h:114:21: note: declared here

maybe due to some update in libnotify? actually I am using version 0.7.1
Comment 1 Holger Berndt 2011-04-03 02:59:52 UTC 
Yes, libnotify changed API. You can build without libnotify support using the --disable-libnotify configure switch.
Comment 2 Christian Faulhammer 2011-04-10 19:16:17 UTC 
Created attachment 966 [details]
Patch to build with libnotify 0.7

Contains #IFs to be compatible with older libnotify versions.  Taken from Gentoo repository, created by Samuli Suominen ssuominen@gentoo.org
Comment 3 detrito 2011-04-13 17:06:24 UTC 
Created attachment 968 [details]
modify value of  LIBNOTIFY_TOO_HIGH

thanks you for reporting here the patch!

however, in order to ebable libnotify support I additionally needed to modify the LIBNOTIFY_TOO_HIGH value in the configure file.

attached patch for notification_plugin-0.27

now it works fine :)
Note You need to log in before you can comment on or make changes to this bug.