Bug 2381 - [PATCH] Update for NetworkManager 0.9
Summary: [PATCH] Update for NetworkManager 0.9
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.7.9
Hardware: All Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2011-03-15 16:23 UTC by Mikhail Efremov
Modified: 2011-03-18 08:22 UTC (History)
0 users

See Also:


Attachments
nm09-support.patch (1.21 KB, patch)
2011-03-15 16:23 UTC, Mikhail Efremov
no flags Details | Diff
Patch that fixes build with old nm (2.09 KB, patch)
2011-03-15 17:25 UTC, Colin Leroy
no flags Details | Diff
nm09-support2.patch (1.54 KB, patch)
2011-03-15 19:13 UTC, Mikhail Efremov
no flags Details | Diff

Description Mikhail Efremov 2011-03-15 16:23:10 UTC
Created attachment 949 [details]
nm09-support.patch

Support for the new connections states in NM 0.9.
The old value of NM_STATE_CONNECTED is defined as OLD_NM_STATE_CONNECTED for the backward compatibility.
StateChange signal is deprecated since NM 0.7 and removed in NM 0.9.
Comment 1 Colin Leroy 2011-03-15 17:25:00 UTC
Created attachment 950 [details]
Patch that fixes build with old nm

Thanks!
The problem is it breaks build when using NM < 0.9.
Could you test that patch instead ?
Comment 2 Mikhail Efremov 2011-03-15 19:13:51 UTC
Created attachment 951 [details]
nm09-support2.patch
Comment 3 Mikhail Efremov 2011-03-15 19:14:16 UTC
Oops, I did miss this.
NM 0.9 is not released yet and its version is 0.8.996 at the moment. The new states were added since NM 0.8.992, so the version check should be PKG_CHECK_MODULES(HAVE_NM_09, NetworkManager >= 0.8.992.
Or it can be checked with the new NM_CHECK_VERSION macro, see this patch.
I tested both patches (your with fixed version check).
Comment 4 users 2011-03-15 19:31:45 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2011-03-15 [colin]	3.7.8cvs64

	* AUTHORS
	* src/gtk/authors.h
	* src/main.c
		Fix bug #2381, "Support for NetworkManager 0.9".
		Patch by Mikhail Efremov

Note You need to log in before you can comment on or make changes to this bug.