Created attachment 868 [details] see the button on the right Since a few versions (I had not taken the time to report a bug since then) the icon to clean the filter field on the bottom of the messages list ist missing. There still is a very small button though that works as expected. I want to see that little broom again though ;)
Most likely to be a bug in your theme.
Aha. Most likely goes without asking what theme it is? I had that error for at least three of the standard ubuntu themes, which I guess all have an iconset that has the clean icon. I guess setting a standard theme (i.e. simple with gnome icons) would fix this? It doesn't. If you mean the internal theme, also doesn't. Also no warnings on the console when starting. Line 697 in gtk/quicksearch.c looks good, but I do have that icon(gtk-demo shows me stock icons). clear_search = gtk_button_new_from_stock(GTK_STOCK_CLEAR) Maybe you can suggest some further debugging, but I doubt it's a bug in the theme.
Yes i said only the theme but i also though about the GTK+ part dealing with themes. As you saw in the source, claws mail is using GTK_STOCK_CLEAR and it's fairly good. I hope you'll get some more info about it. About debugging i don't think you can get that much from debugging claws mail, also GTK+ by default when doesn't find an icon it shows the GTK_STOCK_MISSING_IMAGE. As you see nothing in there, i suppose there's something wrong in GTK+
If you're using GNOME, you may also want to check the gconf key /desktop/gnome/interface/buttons_have_icons
Err, thanks Holger, that's it. This would not be an issue if claws would simply display the full stock button. However, since I use the vertical layout, the label is manually removed, so the button is smaller. In the other layout modes, it just displays "Clear". Well, I want to have no icons on my gtk buttons though. So the I guess the correct behaviour is to always display that icon, regardless of the setting if vertical layout is selected. The button should not be the stock one and the label set to "" but a button created with the image. (The setting is a setting that users should be able to chose after their liking, after all)
I'm sure i didn't understand you well, so correct me if i'm wrong. Why we should not use stock icons and instead create an image and use this one? What for? In all the layouts it shows the icon+text but in three columns layout it's just the icon. What's wrong with that?
Ok, i've read it better and i understood your problem. So this is not right with the clear button. If you select extended search you'll see other two empty buttons.
Now I don't really understand you :) If extended search is the folder search in the edit menu, then I don't see empty buttons. But if you're saying there is another place with similar problems, maybe they can all be fixed by what I tried to suggest. Instead of using gtk_button_new_from_stock and then removing the label (which might not have an icon if the gconf option is set), create the button for the vertical layout with a normal button and gtk_image_new_from_stock, so it does not care about the gconf optionand hence always displays the icon.
I was talking about quicksearch, extended option on the combo. It's fixed in 3.7.6cvs14
I don't like your fix, Salvatore. We should respect the user's preference for icons on stock buttons in general, and only special-handle the buttons for which the label has been explicitely removed.
Ok, i was aware it isn't the optimal fix but also this is a rare case. I just wanted to keep it simple, that's the reason of this commit. I'll change it
Just as an additional note, the case is actually very un-rare. Ubuntu Lucid has that gconf settings as default (I checked that again), so lots of ubuntu users could possibly and probably do have that bug.
Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.colino.net/claws-mail/ 2010-07-25 [colin] 3.7.6cvs20 * src/common/utils.c Reverse free/use with more logical and safe use/free. Thanks to Michael Rasmussen ! 2010-07-24 [colin] 3.7.6cvs19 * src/gtk/quicksearch.c Finish 3.7.5cvs42 patch. Probably fixes bug 2232, 'freeze when using quick search' 2010-07-11 [iwkse] 3.7.6cvs18 * src/gtk/quicksearch.c Add SMALL_LAYOUT to quicksearch_relayout 2010-07-10 [iwkse] 3.7.6cvs17 * src/mainwindow.h Remove forgotten variable from the last bugfix #2224 2010-07-10 [colin] 3.7.6cvs16 * src/mainwindow.c * src/gtk/quicksearch.c Clean fix for bug #2224: don't mess with GTK settings when handling the layout ourselves is enough 2010-07-09 [iwkse] 3.7.6cvs15 * src/mainwindow.h * src/mainwindow.c Better fix for Bug #2224 2010-07-09 [iwkse] 3.7.6cvs14 * src/mainwindow.c Bug #2224 Always use stock icons on buttons 2010-07-08 [colin] 3.7.6cvs13 * src/gtk/filesel.c Fix bug 2223, 'Compilation fails with GTK+ 2.21.3'. Thanks to Jan Psota ! Do not add into quicksearch history matching rules with bad syntax Fix bug 2208. Encode encrypted password to qouted printable to avoid making invalid XML. Encoding will be activated the first time the password is changed.