Currently, the "wrap quotation" is a global preference. As I often reply to patches, I'd prefer keeping this option unset. But sometimes, I receive e-mails sent by crappy mailers and the contents of these mails is not wrapped. So I'd like to manually be able to wrap the mail using the Ctrl+L or Ctrl+A+L shortcuts, but these do not operate when the "wrap quotation" global preference is unset. Would it be possible to keep Ctrl+L and Ctrl+A+L working to manually wrap, even when "wrap quotation" is disabled ? Thanks!
This would require another hidden option...to override the general setting. what do you think?
Why keeping Ctrl+L and Ctrl+Alt+L working even when "wrap quotation" is disabled is a problem ? Sounds to me like the "wrap quotation" preference is what should happen automatically, but that it shouldn't prevent manual wrapping using Ctrl+L and Ctrl+Alt+L from working. In src/compose.c, compose_beautify_paragraph(), if you do : gboolean wrap_quote = force || prefs_common.linewrap_quote; instead of the original gboolean wrap_quote = prefs_common.linewrap_quote; Then, even when quotation wrapping is disabled, Ctrl+L and Ctrl+Alt+L keep working.
Because it's inconsistent. If wrap quotation is disabled you would expect that it's disabled, not that works when you call it from the menu. That's why i said it would be needed an override option. And yes, the problem isn't surely implementing it, thanks for the hint though :-)
Well, I find the current behaviour inconsistent: it's not because *automatic* quotation wrapping, as defined by the preferences is disabled, that you don't want to keep the ability to manually wrap one paragraph or the full text :-)
You're getting it wrong. It already works in this way. If you have automatic wrapping disabled, you still can wrap quotation and other text. If you disable wrap quotation, than it's normal to have it disabled.
> If you have automatic wrapping disabled, you still > can wrap quotation and other text. I'm sorry but no, that's not what I'm seeing. If I disable "wrap quotation" in the presence, I cannot anymore force wrapping using Ctrl+L in the compose window. My use case is the following one : * I reply to a lot of patches, and for those, I don't want automatic wrapping of the quotation, because it wraps the patch, which is inconvenient both for me and for the other readers. * I also sometimes reply to mails sent by people whose MUA doesn't wrap the text, so when replying, I'd like to wrap the text I'm quoting from them. Since for the first use case I disabled "wrap quotation" in the preferences, I'd like to be able to manually force the rewrapping of the quotations using Ctrl+L. For the moment, the only solution is to go into the preferences and tick/untick the "wrap quotation" option when I switch back and forth between the first and second use case, which is pretty annoying.
Changes related to this bug have been committed. Please check latest Git and update the bug accordingly. You can also get the patch from: http://git.claws-mail.org/ ++ ChangeLog 2014-05-22 15:41:03.634014296 +0200 http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1d818e67b3ab5708a9376f1da0cda223f5e42703 Merge: b504e4c eba3ff6 Author: Colin Leroy <colin@colino.net> Date: Thu May 22 15:41:03 2014 +0200 Merge branch 'master' of file:///home/git/claws http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=eba3ff6f6f06cf91fe0016a706073696d3839531 Author: Colin Leroy <colin@colino.net> Date: Thu May 22 15:40:24 2014 +0200 Fix bug #2179, "Improve quotation wrapping support": Make manual wrapping also wrap quotes.