Bug 1975 - preference mutt key bindings do not take effect
Summary: preference mutt key bindings do not take effect
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.7.3
Hardware: Other other
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2009-08-07 20:48 UTC by hemant
Modified: 2013-01-14 10:42 UTC (History)
1 user (show)

See Also:


Attachments

Description hemant 2009-08-07 20:48:56 UTC
version 3.7.2cvs15
OSX - x11. (build from source code, running on fluxbox)
When I set the preferences -> other -> miscelleneous -> keyboard shortcuts

I select the mutt key bindings. After applying only shortcuts like 'g', etc work, but to scroll emails 'j', 'k' dont work.
Comment 1 Colin Leroy 2012-09-12 11:35:20 UTC
The keybinds in src/prefs_other.c (prefs_keybind_apply_clicked function) are incomplete. It would be nice if a Mutt user completed them.
Comment 2 Ricardo Mones 2012-09-12 12:24:05 UTC
Challenge accepted!
Comment 3 Ricardo Mones 2012-09-12 15:11:58 UTC
Unfortunately setting some current Mutt keys is not even possible: escape cannot be used as modifier, for example. And, of course, the tab key which is already usurped^Whandled by GTK or some common WM accelerators.

As they cover important functions, will be workarounded to completely different keys, with the hope of keeping a Mutt feeling though ;-)
Comment 4 users 2012-10-10 01:59:35 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.claws-mail.org/tracker/

2012-10-09 [mones]	3.8.1cvs86

	* doc/man/claws-mail.1
	* src/compose.c
	* src/common/utils.c
		New extra headers feature for adding user-defined
		extra headers to the combobox in the compose window
		Headers are stablished in 'extraheaderrc', one per
		line with a final colon

		Fix for not searching in folders marked 'no_select'
		patch provided by Colin.
	* src/action.c                                                          
		Removed dup calls with ignored result
	* src/addr_compl.c						      
		Removed unused var is_group and simplified logic around it      
	* src/addrharvest.c						     
	* src/matcher.c
	* src/procmsg.c							 
	* src/etpan/etpan-thread-manager.c				      
		Use unused var r to verify result and emit messages on error
	* src/compose.c							 
		Move color variable into conditional usage blocks
		Remove assigned but not used vars: lock, titles, count	  
	* src/edittags.c
		Remove assigned but not used var actions			
	* src/folderview.c
		Remove assigned but not used vars: from_parent, src_node	
	* src/imap_gtk.c
	* src/mh_gtk.c							  
		Remove malloc-ed but not used var: old_path		     
	* src/news.c
		Comment unused vars from commented block: tofetch, fetched      
	* src/prefs_account.c
		Remove assigned but not used var: privacy_enabled
	* src/prefs_actions.c
	* src/prefs_customheader.c
		Remove assigned but not used var: store
	* src/prefs_filtering.c
		Remove assigned but not used var: n_rows
	* src/prefs_template.c
		Remove assigned but not used vars: model, list_store
	* src/prefs_toolbar.c
		Remove assigned but not used var: win_titles
	* src/printing.c
		Remove assigned but not used vars: orientation, line, baseline,
		off_chars 
	* src/etpan/imap-thread.c
		Remove assigned but not used var: value, r
		Refactor to check correct memory allocation
	* src/etpan/nntp-thread.c
		Remove assigned but not used var: value
	* src/gtk/gtkaspell.c
		Remove assigned but not used vars: textbuf, exist
		Remove unused function: find_gtkaspeller
	* src/gtk/gtkcmctree.c
		Remove unused function: gtk_cmctree_get_offset
	* src/gtk/gtkshruler.c
		Remove assigned but not used vars: ruler, priv
		Fix bug #1975 'preference mutt key bindings do not take
		effect' (and the other invalid paths too)

Note You need to log in before you can comment on or make changes to this bug.