Bug 1924 - Messages marked move to Trash appear identical to messages marked move to $FOLDER
Summary: Messages marked move to Trash appear identical to messages marked move to $FO...
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.7.10
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2009-05-29 16:41 UTC by Little Girl
Modified: 2012-06-27 11:26 UTC (History)
1 user (show)

See Also:


Attachments
Screenshot of what headers currently look like when marked to move. (75.75 KB, image/png)
2009-10-30 18:26 UTC, Little Girl
no flags Details
Mockup of difference between headers moved to Trash and moved elsewhere. (69.79 KB, image/png)
2009-10-30 18:28 UTC, Little Girl
no flags Details
Possible patch (1.12 KB, patch)
2011-11-07 09:19 UTC, Colin Leroy
no flags Details | Diff

Description Little Girl 2009-05-29 16:41:27 UTC
Overview: When marking messages to move them to other folders, their appearance is identical to messages marked to be moved to Trash.

Steps to Reproduce: Open a folder in Claws Mail and mark one message to be moved to Trash and mark another to be moved to any other folder.

Actual Results: The marked messages will each have a < in the Mark column and will be displayed in blue text, unless already colorized. 

Expected Results: It would be nice to have strike-through text on messages that are marked to be moved to Trash so they can easily be visually distinguished when reviewing the move choices.

Build: 2009-03-06 Claws Mail 3.7.1 on Kubuntu 8.04 LTS
Comment 1 Little Girl 2009-10-30 18:26:37 UTC
Created attachment 740 [details]
Screenshot of what headers currently look like when marked to move.
Comment 2 Little Girl 2009-10-30 18:28:20 UTC
Created attachment 741 [details]
Mockup of difference between headers moved to Trash and moved elsewhere.
Comment 3 Little Girl 2009-10-30 18:31:15 UTC
I figured since this enhancement request hasn't received any love, I'd attach a couple of screenshots showing what headers look like currently and a mockup of what they could look like.

Header1.png shows eleven headers. One of the messages is being moved to another folder so I can keep it. The other ten are being moved to Trash. You can't tell by looking at the headers which of the messages are being kept.

Header2.png uses strikethrough to differentiate between messages being moved to Trash from those being kept. This way you can tell at a glance which are which.
Comment 4 Little Girl 2010-09-30 14:09:52 UTC
Since this report has been here for over a year with the only activity being mine, I thought I'd bump it to perhaps draw the attention of a kind developer who wouldn't mind adding an option to use strike-through text on messages marked Move to trash.
Comment 5 Little Girl 2010-11-30 14:32:41 UTC
It's the one and a half year anniversary for this enhancement report. (:

I changed the Claws Mail version in this report from 3.7.1 to 3.7.7 since the enhancement doesn't exist in this version either and I'm still hoping someone will agree that it's a good idea.
Comment 6 Paul 2010-11-30 19:14:45 UTC
> It's the one and a half year anniversary for this enhancement report. (:

What?!? you didn't submit a patch yet?!? :-)
Comment 7 Little Girl 2010-12-01 02:26:56 UTC
Blast! I knew I'd forgotten something! (:
Comment 8 Little Girl 2011-11-05 19:00:03 UTC
It's the two and a half year anniversary for this enhancement report. (:

I changed the Claws Mail version in this report from 3.7.7 to 3.7.10 since the
enhancement doesn't exist in this version either and I'm still hoping someone
will agree that it's a good idea.
Comment 9 Ricardo Mones 2011-11-07 01:17:50 UTC
I agree is a good idea, though is probably
Comment 10 Ricardo Mones 2011-11-07 01:19:46 UTC
I agree is a good idea, though is probably better just changing the icon for a little trash instead of the subject striking. Still I found no patch to commit ;-) so I'll have to find time to fix it, which is way harder.
Comment 11 Colin Leroy 2011-11-07 09:19:16 UTC
Created attachment 1037 [details]
Possible patch

Hi Little Girl,

You're patient, aren't you :)

What about that patch ? It sets mail set to move to trash the same color as deleted (but not expunged) mails, with the move icon in addition.

I'm not sure I want to put some strike-through.
Comment 12 Little Girl 2011-11-08 20:47:25 UTC
Thank you to both of you for your interest in this enhancement! (:

I've got Claws Mail installed via my package manager so I can't try the patch, but will happily try it out when the next version of Claws comes out. Currently, if you mark a message to be moved, it gets colored dark blue and it gets a move icon next to it, regardless of whether it's being moved to a folder to be kept or being moved to trash. From the description of the patch, it sounds like the same thing would happen, so it probably wouldn't be a solution.

I also seem to have found a bug, which may already have been reported, in marked messages that have custom colored headers. When it comes to using color to mark a message for moving or deletion, that only works fine as long as the user hasn't assigned custom colors to message headers. Custom header colors applied by filters aren't overridden when marking a message. Even if they were, the user's custom color choice could conflict with the color chosen for marked messages. The only way coloring a marked message could consistently work is if it overrode custom colors and if it used a color not available to the user.

This is one of the reasons I think using strike-through to distinguish messages marked move to trash would be a good idea. It would be immediately obvious regardless of the header colors, and the headers would still be readable.
Comment 13 Little Girl 2012-01-09 06:19:01 UTC
I love the new little icon in the Mark column in Claws Mail 3.8.0 letting me know the difference between the two kinds of moves. Thank you so much for adding this enhancement! (:
Comment 14 Little Girl 2012-01-09 06:25:58 UTC
I spoke too soon - sorry about that! It seem the icon is for copy and not move. ):
Comment 15 Colin Leroy 2012-01-09 19:46:44 UTC
Oups, I completely forgot to commit that patch.
Comment 16 users 2012-01-09 19:48:35 UTC
Changes related to this bug have been committed.
Please check latest CVS and update the bug accordingly.
You can also get the patch from:
http://www.colino.net/claws-mail/

2012-01-09 [colin]	3.8.0cvs12

	* src/summaryview.c
		Fix bug 1924, 'Messages marked move to Trash appear 
		identical to messages marked move to $FOLDER'
Comment 17 Little Girl 2012-01-10 05:17:39 UTC
Thank you! I'll check it out (and most likely close this enhancement request) when the next version is released since I don't use the CVS version. (:

Note You need to log in before you can comment on or make changes to this bug.