Bug 1797 - quicksearch could also search the Cc field
Summary: quicksearch could also search the Cc field
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.6.1
Hardware: All All
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2008-12-14 13:39 UTC by jmcp
Modified: 2015-01-05 11:07 UTC (History)
1 user (show)

See Also:


Attachments
adds code to support search of Cc field in quicksearch (729 bytes, patch)
2008-12-14 13:41 UTC, jmcp
no flags Details | Diff
Updated patch against git head (1.11 KB, patch)
2014-12-09 19:13 UTC, Barry Warsaw
no flags Details | Diff

Description jmcp 2008-12-14 13:39:53 UTC
One feature that I miss from thunderbird is the ability to search on the
Cc field as well as To/From/Subject or Tag. 

I've attached a small patch which makes this possible. I'm running with this
on Solaris Express build snv_103.



--- ../claws-cvs/claws/src/gtk/quicksearch.c	Fri Aug  8 02:38:22 2008
+++ src/gtk/quicksearch.c	Sun Dec 14 17:27:57 2008
@@ -584,7 +584,7 @@
 			 G_CALLBACK(searchtype_changed),
 			 quicksearch);
 	MENUITEM_ADD (search_type, menuitem,
-			_("From/To/Subject/Tag"), QUICK_SEARCH_MIXED);
+			_("From/To/Cc/Subject/Tag"), QUICK_SEARCH_MIXED);
 	g_signal_connect(G_OBJECT(menuitem), "activate",
 	                 G_CALLBACK(searchtype_changed),
 			 quicksearch);
@@ -940,6 +940,8 @@
 	case QUICK_SEARCH_MIXED:
 		if (msginfo->to)
 			to = g_utf8_casefold(msginfo->to, -1);
+		if (msginfo->cc)
+			to = g_utf8_casefold(msginfo->cc, -1);
 		if (msginfo->from)
 			from = g_utf8_casefold(msginfo->from, -1);
 		if (msginfo->subject)
Comment 1 jmcp 2008-12-14 13:41:36 UTC
Created attachment 651 [details]
adds code to support search of Cc field in quicksearch

Messaging (.po) files need updating to make this fix complete
Comment 2 jmcp 2008-12-14 14:18:53 UTC
Applicable to all OSen that claws-mail runs on.
Comment 3 Barry Warsaw 2014-12-09 19:12:33 UTC
The patch from 2008-12-14 no longer applies.  I'll attach a patch against git head which works for me.
Comment 4 Barry Warsaw 2014-12-09 19:13:18 UTC
Created attachment 1457 [details]
Updated patch against git head
Comment 5 Barry Warsaw 2015-01-02 22:44:38 UTC
Any chance you can land this?
Comment 6 Brian Morrison 2015-01-03 00:48:15 UTC
You can do this in extended mode using c or C command followed by search text
Comment 7 Barry Warsaw 2015-01-04 21:05:29 UTC
Sure, but that's not very convenient is it?   I'm not sure why you'd want to search To but not CC.
Comment 8 users 2015-01-05 11:00:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2015-01-05 11:00:02.622574471 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=b88061ed501a9959b16fc18d2f2f32bfc2376624
Merge: 3720167 d4fa1c0
Author: Colin Leroy <colin@colino.net>
Date:   Mon Jan 5 11:00:02 2015 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d4fa1c076942efbf17094123c14530d607fb6d09
Author: Ricardo Mones <ricardo@mones.org>
Date:   Mon Jan 5 10:55:52 2015 +0100

    Fix bug #1797 “quicksearch could also search the Cc field”
    
    Updated patch by Barry Warsaw <barry@python.org>, thanks!

Note You need to log in before you can comment on or make changes to this bug.