Bug 1774 - [PATCH] add missing translations back
Summary: [PATCH] add missing translations back
Status: RESOLVED WONTFIX
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.6.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2008-11-14 17:26 UTC by Stanislav Brabec
Modified: 2008-11-16 14:33 UTC (History)
0 users

See Also:


Attachments
claws-mail-locales.patch (680 bytes, patch)
2008-11-14 17:27 UTC, Stanislav Brabec
no flags Details | Diff
claws-mail-po-fix.sh (1.67 KB, text/plain)
2008-11-16 00:25 UTC, Stanislav Brabec
no flags Details

Description Stanislav Brabec 2008-11-14 17:26:36 UTC
Even if translator did not update translation for the latest version, incomplete translations are better than nothing. It is a general policy of most collaborative projects. Presence if incomplete translation in the package also prevents duplication of the work and may encourages some users to take maintenance.

Note: if you are creating release tarballs by "make dist", attachec patch should be sufficient. Otherwise, you may pick all translations manually.
Comment 1 Stanislav Brabec 2008-11-14 17:27:03 UTC
Created attachment 642 [details]
claws-mail-locales.patch
Comment 2 Colin Leroy 2008-11-14 17:46:17 UTC
We disabled them on purpose, to motivate translators; it paid, three of the removed translation have been updated on 3.6.0 :)
Comment 3 Paul 2008-11-14 17:48:28 UTC
We disagree. We decided to remove them from the release tarballs, but have left
them in CVS, (so no duplication is necessary). And it wasn't just that they
weren't updated for the last release, but hadn't been updated in 6 months or
so.

We did this to encourage new translators to come forward, and it had some
success.
Comment 4 Stanislav Brabec 2008-11-16 00:23:57 UTC
Updated patch: http://www.penguin.cz/~utx/ftp/claws-mail/claws-mail-po-update.patch
(6MB)

Fixes most visible strings modifying outdated translations in previous po files.

Patch improves:
cs.po: before 2113 translated messages, after 2401 translated messages
el.po: before 1480 translated messages, after 1714 translated messages
he.po: before 837 translated messages, after 1127 translated messages
hr.po: before 1063 translated messages, after 1233 translated messages
ja.po: before 1061 translated messages, after 1231 translated messages
ko.po: before 1115 translated messages, after 1329 translated messages
nb.po: before 1590 translated messages, after 1827 translated messages
sk.po: before 2332 translated messages, after 2623 translated messages
sr.po: before 2216 translated messages, after 2493 translated messages
zh_TW.po: before 1169 translated messages, after 1372 translated messages
Comment 5 Stanislav Brabec 2008-11-16 00:25:15 UTC
Created attachment 643 [details]
claws-mail-po-fix.sh

Script that made this job.
Comment 6 Paul 2008-11-16 11:32:32 UTC
Your patch seems to replicate what 'msgmerge --update [LANG].po claws-mail.pot' does, which happens during a normal build procedure, and thus doesn't change anything.
Sorry!
Comment 7 Stanislav Brabec 2008-11-16 12:38:40 UTC
> Your patch seems to replicate what 'msgmerge --update [LANG].po claws-mail.pot' does

No, it does not!

It adds ~2000 new translations. Please check yourself to start with LANG=cs_CZ.UTF-8 or LANG=sk_SK.UTF-8 before and after my patch.

After my patch, most menus are translated in all languages listed.
Comment 8 Stanislav Brabec 2008-11-16 12:45:22 UTC
The script converts all existing translation from the old "menu path" style translation to the new "one string per item". As the new menu system is less flexible for translators (menu items with identical name and identical English hotkey in different menus have to have identical hotkey in all languages), the script searches for the most often hotkey and uses this one as a new translation.
Comment 9 Stanislav Brabec 2008-11-16 14:33:33 UTC
I forgot to mention:

The script runs on all locales. Only locales that were not updated for the new menu system can be improved: cs.po el.po he.po hr.po ja.po ko.po nb.po sk.po sr.po zh_TW.po.

The patch is valid just now for the CVS and includes only mentioned locales.

If you will use the script, please commit only upper mentioned locates and keep the rest out.

Note You need to log in before you can comment on or make changes to this bug.