Bug 3652

Summary: utils.c:4740:47: warning: ordered comparison of pointer with integer zero [-Wextra]
Product: Claws Mail (GTK 2) Reporter: David Binderman <dcb314>
Component: OtherAssignee: users
Status: RESOLVED FIXED    
Severity: normal    
Priority: P3    
Version: other   
Hardware: PC   
OS: Linux   

Description David Binderman 2016-06-15 18:27:58 UTC
Source code is

    while (i < 60 && score < 3
           && fgets(buffer, sizeof (buffer), fp) > 0) {

Suggest new code

    while (i < 60 && score < 3
           && fgets(buffer, sizeof (buffer), fp) != 0) {
Comment 1 users 2016-06-16 16:30:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2016-06-16 16:30:02.314229950 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=5d455d4a2c3cd4d9b0274a625e00c40a14858aa0
Merge: 1c488fa 804af9b
Author: Colin Leroy <colin@colino.net>
Date:   Thu Jun 16 16:30:01 2016 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=804af9b07981803eda6596ba6e62b8d05979d482
Author: Ricardo Mones <ricardo@mones.org>
Date:   Thu Jun 16 16:28:54 2016 +0200

    Fix bug #3652 “warning: ordered comparison of pointer…”