Bug 3652 - utils.c:4740:47: warning: ordered comparison of pointer with integer zero [-Wextra]
Summary: utils.c:4740:47: warning: ordered comparison of pointer with integer zero [-W...
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: Other (show other bugs)
Version: other
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2016-06-15 18:27 UTC by David Binderman
Modified: 2016-07-12 15:06 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2016-06-15 18:27:58 UTC 
Source code is

    while (i < 60 && score < 3
           && fgets(buffer, sizeof (buffer), fp) > 0) {

Suggest new code

    while (i < 60 && score < 3
           && fgets(buffer, sizeof (buffer), fp) != 0) {
Comment 1 users 2016-06-16 16:30:02 UTC 
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2016-06-16 16:30:02.314229950 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=5d455d4a2c3cd4d9b0274a625e00c40a14858aa0
Merge: 1c488fa 804af9b
Author: Colin Leroy <colin@colino.net>
Date:   Thu Jun 16 16:30:01 2016 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=804af9b07981803eda6596ba6e62b8d05979d482
Author: Ricardo Mones <ricardo@mones.org>
Date:   Thu Jun 16 16:28:54 2016 +0200

    Fix bug #3652 “warning: ordered comparison of pointer…”
Note You need to log in before you can comment on or make changes to this bug.