Summary: | add libappindicator support to notification plugin | ||
---|---|---|---|
Product: | Claws Mail (GTK 2) | Reporter: | HendrikL <hlehmbruch> |
Component: | Plugins/Notification | Assignee: | users |
Status: | RESOLVED WORKSFORME | ||
Severity: | enhancement | CC: | rca |
Priority: | P3 | ||
Version: | 3.11.1 | ||
Hardware: | PC | ||
OS: | Linux |
Description
HendrikL
2015-07-13 07:49:15 UTC
One technical hurdle to overcome is that appindicator does not allow for custom icons from XPM inline in the code, but one has to install an icon file somewhere, and point the library to that path. See http://askubuntu.com/questions/108522/how-to-use-custom-icon-in-an-appindicator : After calling set_icon_theme_path you can reference your-icon.png under the "icon name" your-icon. Good news at least for Debian users, the old-style tray icons will be supported in KDE5 for the foreseeable future, see https://lists.debian.org/msgid-search/1827691445107908@web19m.yandex.ru In the meantime, I have played with libappindicator a bit, and found out that working with it is rather trivial, after you get after one or two initial gotchas. What stopped me is code structure of the notification plugin, where I am not entirely sure what is the best way to add libappindicator support. Logically, this would go right next to notification_trayicon.[ch] as notification_appindicator.[ch], but in notification_trayicon.[ch], there is a lot of code around handling of popup menu and preparing message counts. I do not want to duplicate that code, since that is a surefire way to maintainer's nightmare. I was able to separate the popup menu creation into a notification_core.c (I think), but I am unsure of what to do with the rest. It would help if Holger could have a look at it, and suggest best solution - he knows the notification_plugin code best. :) This is no longer a problem in KDE 5.15.0. |