| Summary: | [PATCH] Update for NetworkManager 0.9 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Claws Mail (GTK 2) | Reporter: | Mikhail Efremov <mikhefr> | ||||||||
| Component: | Other | Assignee: | users | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | 3.7.9 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 950 [details]
Patch that fixes build with old nm
Thanks!
The problem is it breaks build when using NM < 0.9.
Could you test that patch instead ?
Created attachment 951 [details]
nm09-support2.patch
Oops, I did miss this. NM 0.9 is not released yet and its version is 0.8.996 at the moment. The new states were added since NM 0.8.992, so the version check should be PKG_CHECK_MODULES(HAVE_NM_09, NetworkManager >= 0.8.992. Or it can be checked with the new NM_CHECK_VERSION macro, see this patch. I tested both patches (your with fixed version check). Changes related to this bug have been committed. Please check latest CVS and update the bug accordingly. You can also get the patch from: http://www.colino.net/claws-mail/ 2011-03-15 [colin] 3.7.8cvs64 * AUTHORS * src/gtk/authors.h * src/main.c Fix bug #2381, "Support for NetworkManager 0.9". Patch by Mikhail Efremov |
Created attachment 949 [details] nm09-support.patch Support for the new connections states in NM 0.9. The old value of NM_STATE_CONNECTED is defined as OLD_NM_STATE_CONNECTED for the backward compatibility. StateChange signal is deprecated since NM 0.7 and removed in NM 0.9.