Bug 4189 - Box for autocompleting To address is in wrong place
Summary: Box for autocompleting To address is in wrong place
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.99.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2019-03-26 12:52 UTC by Marcel Pol
Modified: 2020-05-19 15:45 UTC (History)
0 users

See Also:


Attachments
Box for autocomplete is in the wrong place (28.41 KB, image/png)
2019-03-26 12:52 UTC, Marcel Pol
Details

Description Marcel Pol 2019-03-26 12:52:29 UTC
Created attachment 1968 [details]
Box for autocomplete is in the wrong place

On todays git of the GTK3 tree, the autocomplete dropdown is in the wrong place.

I open the composer to compose a new message. In the To field, I type part of the name, then press Tab.
The dropdown box with addresses from the address book is shown. It is however on top of the input field for Subject. I think it should be right below the input field for the To address.

See attached screenshot.
I typed 'timelo', then pressed tab. It lists my own address in the dropdown, on top of the Subject field.
Comment 1 Andrej Kacian 2019-03-27 09:23:44 UTC
Looks like this is an issue with all our custom address autocomplete, as the same thing happens elsewhere where it is used, e.g. default recipient entries in folder properties or templates, addressbook search entry, recipient entry for "Resend" filtering actions.

The code tries to place the popup window with completion results right below the entry widget. For some reason, though, when the code responsible for this tries to get the GdkWindow of the entry widget, it seems to get GdkWindow of one of its parent layout widgets - in case of entries in compose window, that seems to be the GtkScrolledWindow inside the "Header" GtkNotebook page.

That's as far as I've got. I can't figure out why this happens.

An idea is to rewrite this address completion functionality to use GTK's native GtkEntryCompletion.
Comment 2 Andrej Kacian 2019-03-29 18:36:36 UTC
Now fixed in git, thanks!
Comment 3 Marcel Pol 2019-03-30 09:19:06 UTC
Thank you, that is fantastic work.

Note You need to log in before you can comment on or make changes to this bug.