Bug 4134 - 'Save message to' option not set when it should be
Summary: 'Save message to' option not set when it should be
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Compose Window (show other bugs)
Version: 3.17.2
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2018-12-15 22:35 UTC by Ralf Mardorf
Modified: 2018-12-18 06:13 UTC (History)
0 users

See Also:


Attachments
Advanced settings (14.15 KB, image/png)
2018-12-16 13:28 UTC, Ralf Mardorf
no flags Details

Description Ralf Mardorf 2018-12-15 22:35:14 UTC
If 3.17.2 is installed and I send mails from at least one of my POP accounts, the sent mail is lost.
For at least one of my other POP accounts this doesn't happen.
If I downgrade to 3.17.1, mails sent from this account are saved again.
I tested this by upgrading and downgrading two times:
$ grep claws-mail /var/log/pacman.log | grep grade | tail -4
[2018-12-15 18:35] [ALPM] upgraded claws-mail (3.17.1-1 -> 3.17.2-1)
[2018-12-15 23:09] [ALPM] downgraded claws-mail (3.17.2-1 -> 3.17.1-1)
[2018-12-15 23:10] [ALPM] upgraded claws-mail (3.17.1-1 -> 3.17.2-1)
[2018-12-15 23:12] [ALPM] downgraded claws-mail (3.17.2-1 -> 3.17.1-1)
Running claws-mail in a terminal doesn't show anything.
Comment 1 Paul 2018-12-15 23:11:30 UTC
You need to give more details than just 'it fails'.

What types of Account (pop, imap)?
Do you have the global option set to save sent msgs?
What are your account settings (on the Advanced page) for saving sent messages?
Do you have the Folder Property set for saving sent msgs in the current folder?
etc
Comment 2 Ralf Mardorf 2018-12-16 01:04:49 UTC
>What types of Account (pop, imap)?

I already mentioned that it is a POP account.

>Do you have the global option set to save sent msgs?

"Save sent messages" is checked.

>What are your account settings (on the Advanced page) for saving sent
>messages?

Nothing is checked, everything is blank.

>Do you have the Folder Property set for saving sent msgs in
>the current folder?

No.

>etc

What additional information do you need?
Comment 3 Paul 2018-12-16 10:24:54 UTC
(In reply to comment #2)

> What additional information do you need?

In the Compose window, when you use the failing account, what is the state of the Others tab? Is the checkbox checked? What is the value shown? If a folder is shown, does it exist?
Comment 4 Ralf Mardorf 2018-12-16 11:10:43 UTC
If I use 3.17.1 it is 

[√] Save Message to [#mh/Claws Mail/sent]

it's checked and an existing folder. 

After upgrading to 3.17.2 it becomes

[ ] Save message to [#mh/Claws Mail/sent]

so it's still the same existing folder, but it's unchecked.

This happens to all folders with the same account settings described by my previous reply, excepted of the default account, with the same settings. For the default account it doesn't become unchecked. Accounts with a folder specified by the advanced settings also don't suffer from this bug. All accounts are POP accounts.
Comment 5 Paul 2018-12-16 11:36:53 UTC
I cannot reproduce this.

Is your #mh/Claws Mail/sent folder actually a folder of type 'Outbox'?

Right-click #mh/Claws Mail/sent, choose 'Properties'. On the General page, is Folder Type set to 'Outbox'?
Comment 6 Ralf Mardorf 2018-12-16 11:52:56 UTC
For 3.17.1 and 3.17.2 it is folder type "Outbox" and it's checked. It's shadowed, I can't uncheck it or select another folder type.
Comment 7 Paul 2018-12-16 12:21:26 UTC
run this command and tell me the output:

grep -rn save_message ~/.claws-mail/clawsrc
Comment 8 Ralf Mardorf 2018-12-16 13:28:17 UTC
Created attachment 1942 [details]
Advanced settings
Comment 9 Ralf Mardorf 2018-12-16 13:28:51 UTC
$ grep -rn save_message ~/.claws-mail/clawsrc 
18:save_message=1
Comment 10 brad@fineby.me.uk 2018-12-16 16:06:09 UTC
I experienced mail loss with v3.17.2git1 on one of my accounts. The lost mails were only those that were replies to messages in the account's inbox.  Replies to messages filtered to other folders appeared in Sent as they should have.

I'm now at 3.17.2git6 and, so far (from a small test sample), replies from the affected account appear in the Sent folder, as expected.
Comment 11 Paul 2018-12-16 16:14:05 UTC
(In reply to comment #10)
> I experienced mail loss with v3.17.2git1 on one of my accounts. The lost
> mails were only those that were replies to messages in the account's inbox. 
> Replies to messages filtered to other folders appeared in Sent as they
> should have.
> 
> I'm now at 3.17.2git6 and, so far (from a small test sample), replies from
> the affected account appear in the Sent folder, as expected.

That's not 'mail loss', it's lack of saving a copy of a sent mail.

If it happened at v3.17.2git1 but not 3.17.2git6 than that suggests that it was entirely random.
Comment 12 Paul 2018-12-16 16:18:23 UTC
(In reply to comment #10)
> The lost
> mails were only those that were replies to messages in the account's inbox. 
> Replies to messages filtered to other folders appeared in Sent as they
> should have.

Did you inspect the Others tab in the Compose window during that? This is about the option to save the sent message not being set when it should be.
Comment 13 Paul 2018-12-16 16:44:30 UTC
Ralf, what are the values of 'inbox' for each of the accounts in ~/.claws-mail/accountrc? Please also indicate which is the default account.
Comment 14 Ralf Mardorf 2018-12-16 17:26:11 UTC
I added comments and empty lines as separator to the grep output and shortened the addresses.

$ grep -e address -e inbox -e sent ~/.claws-mail/accountrc 
address=[snip]alice-dsl.net
inbox=#mh/Claws Mail/inbox
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=0
sent_folder=

address=[snip]rocketmail.com     ### This is the default account
inbox=#mh/Claws Mail/inbox
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=0
sent_folder=

address=[snip]rocketmail.com
inbox=#mh/Claws Mail/inbox
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=0
sent_folder=

address=[snip]zoho.com
inbox=#mh/Claws Mail/inbox
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=1
sent_folder=#mh/Claws Mail/The shared/KDE+Ubuntu+

address=[snip]yahoo.com
inbox=#mh/Claws Mail/inbox
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=0
sent_folder=

address=[snip]rocketship.com     ### For this account 'Get Mail' is disabled
inbox=#mh/Claws Mail/trash
local_inbox=#mh/Claws Mail/inbox
set_sent_folder=1
sent_folder=#mh/Claws Mail/trash ### moving to trash is wanted for this account


Incoming mails are filtered, the last filter rule is

$ tail -2 ~/.claws-mail/matcherrc
enabled rulename "End Share Inbox" all move "#mh/Claws Mail/The shared"

so mails are not stored in the default inbox, they either have their own folders or are saved in 'The shared' folder.
Comment 15 brad@fineby.me.uk 2018-12-17 10:19:49 UTC
(In reply to comment #11)

> That's not 'mail loss', it's lack of saving a copy of a sent mail.

Indeed.  My apologies.  A poor choice of words on my part.

> If it happened at v3.17.2git1 but not 3.17.2git6 than that suggests that it
> was entirely random.

Except that two people experienced a similar sequence of events, and those events were repeatable.
Comment 16 brad@fineby.me.uk 2018-12-17 10:22:18 UTC
(In reply to comment #12)
> Did you inspect the Others tab in the Compose window during that? This is
> about the option to save the sent message not being set when it should be.

Set to "Save to Sent"
Comment 17 users 2018-12-17 11:21:05 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2018-12-17 12:21:05.099462324 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=6f9b6e1626343e64e5ef038bb4236aad0cdd9373
Author: Paul <paul@claws-mail.org>
Date:   Mon Dec 17 11:20:13 2018 +0000

    fix bug 4134, ''Save message to' option not set when it should be'
Comment 18 Paul 2018-12-17 11:26:52 UTC
Eventually, I managed to reproduce this, (thanks to extra diagnostic by Andrej). It only happen[s|ed] when changing account in the Compose window. I assume this is the same for you but it is a detail you left out.
Comment 19 Ralf Mardorf 2018-12-18 06:13:32 UTC
Thank you, the issue is fixed.

Note You need to log in before you can comment on or make changes to this bug.