Bug 4055 - Overriding "work offline" doesn't update icon indicator
Summary: Overriding "work offline" doesn't update icon indicator
Status: NEW
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI (show other bugs)
Version: 3.17.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
: 4178 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-07-15 10:06 UTC by George
Modified: 2019-03-17 12:29 UTC (History)
0 users

See Also:


Attachments

Description George 2018-07-15 10:06:28 UTC
STR:

1. Switch to offline mode
2. Try to do something which requires connection (check mail, update RSS feed)
3. When asked "You're working offline. Override?" click Yes

EXPECTED:

The icon in at bottom right which shows "offline" should update to "online" and after the overridden time expires - the icon should switch to offline, thus reflecting the actual stata.

ACTUAL:

The icon shows "offline".

IDEA:

Have an additional icon indicating that it is an override. Examples:

- an online icon with a small clock in it (may require themes updates?)
- or simply a number counting down the remaining minutes/seconds till going offline


[version 3.16.0git237]
Comment 1 Shai Berger 2018-07-21 19:33:30 UTC
I disagree -- the "override", as far as I understand it, does not change the program state, but just allows the single requested action to access the network in spite of the program state. In other words, the ticket expresses an assumption that the override changes the whole program state for a limited time, but that assumption is, as far as I understand, incorrect.

If I'm right, the icon displaying the mode as "offline" is still correct even during the overriding operation (e.g -- just because you're allowing a message to be sent, doesn't mean an automatic mail fetch can be triggered -- that other operation is still blocked by the "offline" state).

The fact that an "online operation" is being carried out is presented clearly enough by progress bars, and in the case of sending messages, even a separate dialog box.

Therefore, I suggest this ticket be closed as "invalid".
Comment 2 George 2018-07-21 20:23:40 UTC
> the "override", as far as I understand it, does not
> change the program state, but just allows the single
> requested action to access the network in spite of
> the program state.

That is incorrect. Check bug#4056 - CM remains online and you can make more requests, not just a single one.

> Therefore, I suggest this ticket be closed as
> "invalid".

You are protesting against a bug report without even
testing. I don't know why.

FWIW: I can reproduce it also in 3.16.0git242
Comment 3 Shai Berger 2018-07-21 21:48:30 UTC
(In reply to comment #2)
> > the "override", as far as I understand it, does not
> > change the program state, but just allows the single
> > requested action to access the network in spite of
> > the program state.
> 
> That is incorrect. Check bug#4056 - CM remains online and you can make more
> requests, not just a single one.
> 

I stand corrected.

> > Therefore, I suggest this ticket be closed as
> > "invalid".
> 
> You are protesting against a bug report without even
> testing. I don't know why.
> 

I was not "protesting", I expressed an opinion based on my understanding. My understanding was, apparently, wrong, and I take back my suggestion.
Comment 4 Paul 2019-03-17 12:29:58 UTC
*** Bug 4178 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.