Bug 3931 - segfault searching server with master password
Summary: segfault searching server with master password
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: UI/Address Book/LDAP (show other bugs)
Version: 3.16.0
Hardware: PC Linux
: P3 major
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2017-12-07 01:26 CET by Ricardo Mones
Modified: 2017-12-10 18:24 CET (History)
0 users

See Also:


Attachments
gdb backtrace of the crash (5.95 KB, text/plain)
2017-12-07 01:26 CET, Ricardo Mones
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Mones 2017-12-07 01:26:05 CET
Created attachment 1821 [details]
gdb backtrace of the crash

Requires:
• A working LDAP server configured in Address Book
• Use master password

Steps to reproduce:
• Open Address Book
• Select configured LDAP server
• Enter some search term on the search entry
• Press the Find button

Result:
Segmentation fault (backtrace attached).

Expected:
Master dialog pops-up asking for password, password is entered and query is performed.

Thanks in advance,
Comment 1 users 2017-12-10 18:14:03 CET
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2017-12-10 18:14:03.093337675 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=fcff54c23bcab3ddb3c0d3d7c0e700049427adc0
Merge: 446fd06 e0f4140
Author: Colin Leroy <colin@colino.net>
Date:   Sun Dec 10 18:14:02 2017 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e0f41407ce397eed880ba0360d9b5725f9176ed8
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 10 10:49:02 2017 +0100

    Fix bug 3931: segfault searching server with master password
    
    Request master passphrase earlier and inhibit search if no master
    passphrase is available.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=48f72c22f91fbe0d6e872e89bd4dce9d39090e81
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 10 10:49:01 2017 +0100

    Fix bug 3793: segfault when autocompletion asks for master passphrase
    
    This is done by checking early if any ldap server is password-protected,
    and asking for master passphrase when compose window appears.  If user
    cancels the dialog (does not enter the passphrase), we temporarily
    disable the password-protected LDAP servers, just for that particular
    compose window. We reenable them in compose_destroy().

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=d954a01de48f90a726e79995f4daeed3e9fee11b
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 10 10:49:00 2017 +0100

    Add public call to get master password