Steps to reproduce:
• Have some header in extraheaderrc, for example:
$ echo "X-Test-Header:" >> ~/.claws-mail/extraheaderrc
• Start Claws Mail and open Compose window
• Select "X-Test-Header:" in one entry's combobox
• Input some value on the entry, for example "test value"
• Send the message (probably 'Send later' is enough, but haven't tested)
• Go to the folder your sent messages are saved and view source of the just
sent message (or queue, if you 'Send later')
Expected line in message: "X-Test-Header: test value"
Actual line in message: "(null) test value"
That's a regression, so probably should be addressed before release. Probably related to http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=c0505b80
but not sure.
Thanks in advance,
Same problem when sending a message after adding a custom header (provided that the compose window's header name is editable).
I also noticed that such header has no space between the header name and value, like:
A git bisect session has confirmed the first commit where this is broken is c0505b80.
Looking at the patch seems the compose_untranslated_header_name() added in that commit should not return NULL if the header is unknown, maybe should simply return the header as is. Rationale: unknown headers are not translatable, so they're already untranslated.
I'll give this a closer look during this week-end, hopefully fixing it (be)for(e) the string freeze.
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
++ ChangeLog 2017-03-19 12:15:03.148402605 +0100
Merge: bcc89fb 3595d6c
Author: Colin Leroy <email@example.com>
Date: Sun Mar 19 12:15:02 2017 +0100
Merge branch 'master' of file:///home/git/claws
Author: wwp <firstname.lastname@example.org>
Date: Sun Mar 19 12:13:28 2017 +0100
Fix bug 3785: custom headers not stored in queued messages (and thus,