Bug 3467 - Preferencies are not saved before clean exit
Summary: Preferencies are not saved before clean exit
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI (show other bugs)
Version: 3.10.1
Hardware: All All
: P3 enhancement
Assignee: users
URL:
: 3522 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-14 18:19 UTC by daniel
Modified: 2015-09-20 19:31 UTC (History)
2 users (show)

See Also:


Attachments

Description daniel 2015-07-14 18:19:34 UTC
If any preferencies are changed via settings>options dialogue they are saved within current claws session but are not saved permanently. So if the claws will crash in the meantime and is not closed properly, changes in preferencies are not saved for another session. 

However killing claws using task manger is not enough. 

To reproduce:
1) open settings > options and change something
2) (this is necessary only as a way to crash claws anytime) in setting > option turn on html reading of messages, hit OK and try to print email when viewing it in html. print will cause claws to crash.
Comment 1 users 2015-08-28 11:42:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2015-08-28 11:42:02.514478363 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9d481d474c890482b923d1fed91c925b1e7864a0
Merge: 484e846 8bc08f3
Author: Colin Leroy <colin@colino.net>
Date:   Fri Aug 28 11:42:02 2015 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8bc08f388d4f8cd6a8f76a7d0383c16f0cea572f
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 13:09:46 2015 +0200

    Add a PrefsWindow callback for apply button, and use it for common preferences to save them to disk.
    
    Fixes bug #3467 for "click Apply, then click Cancel" scenario.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=4cf741e58e39af25d3ccd00b91197f5df9adc054
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:08:08 2015 +0200

    Use PrefsWindow's close_cb callback to save common prefs to disk, if OK or Apply button was pressed.
    
    Fixes bug #3467.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f3593ce1b2b2c33681e0e251e317478c45533cbb
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:05:07 2015 +0200

    Added dialog_response member to PrefsWindow.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f0cc04183e634bec1265a8e9e0cd1037125f2034
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:00:00 2015 +0200

    Pass PrefsWindow pointer instead of GtkWindow to prefswindow's open and close callbacks.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=05a137be880855c9e002fa30cdab705ac66fd64a
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 11:56:13 2015 +0200

    Moved struct and enum declarations from prefswindow.c to .h.
Comment 2 users 2015-08-28 11:42:05 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2015-08-28 11:42:02.514478363 +0200
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9d481d474c890482b923d1fed91c925b1e7864a0
Merge: 484e846 8bc08f3
Author: Colin Leroy <colin@colino.net>
Date:   Fri Aug 28 11:42:02 2015 +0200

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=8bc08f388d4f8cd6a8f76a7d0383c16f0cea572f
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 13:09:46 2015 +0200

    Add a PrefsWindow callback for apply button, and use it for common preferences to save them to disk.
    
    Fixes bug #3467 for "click Apply, then click Cancel" scenario.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=4cf741e58e39af25d3ccd00b91197f5df9adc054
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:08:08 2015 +0200

    Use PrefsWindow's close_cb callback to save common prefs to disk, if OK or Apply button was pressed.
    
    Fixes bug #3467.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f3593ce1b2b2c33681e0e251e317478c45533cbb
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:05:07 2015 +0200

    Added dialog_response member to PrefsWindow.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=f0cc04183e634bec1265a8e9e0cd1037125f2034
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 12:00:00 2015 +0200

    Pass PrefsWindow pointer instead of GtkWindow to prefswindow's open and close callbacks.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=05a137be880855c9e002fa30cdab705ac66fd64a
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Thu Aug 27 11:56:13 2015 +0200

    Moved struct and enum declarations from prefswindow.c to .h.
Comment 3 Andrej Kacian 2015-09-20 19:31:08 UTC
*** Bug 3522 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.