Bug 3345 - Ability to choose other From values via keyboard has been lost
Summary: Ability to choose other From values via keyboard has been lost
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail (GTK 2)
Classification: Unclassified
Component: UI/Compose Window (show other bugs)
Version: 3.11.1
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-12-05 01:15 UTC by Barry Warsaw
Modified: 2014-12-08 23:11 UTC (History)
0 users

See Also:


Attachments

Description Barry Warsaw 2014-12-05 01:15:32 UTC
In Claws 3.10, when composing a new message, I used to be able to hit Alt-D to focus on the "Header" tab.  From there, I could use the down arrow to choose which From address I wanted to use.

In Claws 3.11, once I get to the Header tab, down arrow no longer flips through the From addresses.  Instead it moves to the next field, exactly as TAB already does.  There doesn't seem to be any way to select from multiple From values via the keyboard.

Please restore this valuable shortcut!

Claws 3.11.1 on Ubuntu 15.04
Comment 1 users 2014-12-07 22:35:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-12-07 22:35:02.635519314 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=70bd33140aa5e61e2feb8a17683d8672d92f0767
Merge: d4531ca e746281
Author: Colin Leroy <colin@colino.net>
Date:   Sun Dec 7 22:35:02 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e746281f5fd9a7678550c29c5618f67c50ee055b
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 7 22:33:26 2014 +0100

    Compose window: activating the GtkEntry with sender address activates the account selection combobox. Closes bug #3345, reported by  Barry Warsaw.
Comment 2 Andrej Kacian 2014-12-07 22:54:47 UTC
This behavior (pressing down to open address/account selection instead of moving to next header line) was inconsistent with rest of that whole area, so it was removed.

But you are right, there should be a way to select an account with keyboard only. That's why latest commit will allow you to press Enter while in the From address field to enter the account selection combobox. Not the same thing, but functionally the same, and hopefully it is acceptable for you.
Comment 3 users 2014-12-07 23:45:02 UTC
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

++ ChangeLog	2014-12-07 23:44:02.675807118 +0100
http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9a22e2e2c1f109da612228462e4552fb5ba2e9ff
Merge: 70bd331 1ffe0d0
Author: Colin Leroy <colin@colino.net>
Date:   Sun Dec 7 23:34:02 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=1ffe0d0d1a4433fd841d282a9a65161044b08e21
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 7 23:31:41 2014 +0100

    Properly allocate buffer in conv_encode_header_full() for quoted-printable encoding. Closes bug #3338, reported by Michael Hughes.

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=70bd33140aa5e61e2feb8a17683d8672d92f0767
Merge: d4531ca e746281
Author: Colin Leroy <colin@colino.net>
Date:   Sun Dec 7 22:35:02 2014 +0100

    Merge branch 'master' of file:///home/git/claws

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=e746281f5fd9a7678550c29c5618f67c50ee055b
Author: Andrej Kacian <ticho@claws-mail.org>
Date:   Sun Dec 7 22:33:26 2014 +0100

    Compose window: activating the GtkEntry with sender address activates the account selection combobox. Closes bug #3345, reported by  Barry Warsaw.
Comment 4 Barry Warsaw 2014-12-08 16:31:34 UTC
Thanks for adding this functionality back.  I'll retrain my muscle memory to hit Enter instead of down-arrow to pull up the selection combobox.  I ran from git and it seemed fine, except for one minor annoyance.

Previously, you'd hit Alt-D to get to the Header tab, then hit down-arrow to pull up the combobox.  Two keystrokes.

Now you have to hit Alt-D, then TAB to get to the address area, *then* hit Enter to pull up the combobox.  Three keystrokes.

Is there any way you can make Enter pull up the combobox when it's hit while sitting on the Header tab, making it two keystrokes again?  

IOW, Alt-D then Enter
Comment 5 Andrej Kacian 2014-12-08 23:11:41 UTC
I don't really like the approach of Alt-D + Enter, since if a focus is
on the notebook header (and left/right will change notebook pages), I feel
it shouldn't touch "inner" widgets until you explicitly focus into them.

Instead, after latest commit, Alt-F gets you directly to the sender address line.

Note You need to log in before you can comment on or make changes to this bug.