Bug 3112 - Non-ASCII characters in string
Summary: Non-ASCII characters in string
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Plugins (show other bugs)
Version: 3.10.0
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2014-03-17 20:17 CET by Christian Hesse
Modified: 2014-03-21 07:34 CET (History)
0 users

See Also:


Attachments
replace non ASCII-characters (1.22 KB, application/x-download)
2014-03-17 20:17 CET, Christian Hesse
no flags Details
allow UTF-8 charaters in translatable strings (1.71 KB, patch)
2014-03-18 19:47 CET, Christian Hesse
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Hesse 2014-03-17 20:17:53 CET
Created attachment 1349 [details]
replace non ASCII-characters

Compilation fails because of non-ASCII characters in string:

/usr/bin/xgettext: Non-ASCII string at src/plugins/libravatar/libravatar.c:438.
                   Please specify the source encoding through --from-code.
Makefile:400: recipe for target 'claws-mail.pot-update' failed

Patch is attached.
Comment 1 Paul 2014-03-18 11:02:30 CET
thanks for the patch!
Comment 2 Ricardo Mones 2014-03-18 18:30:46 CET
Despite the first diff is correct (because it's how menu path references are usually written within the project), the quotes (or other UTF-8 char) should represent no problem, so fallback to ASCII is not the right fix.

Proposal is to add "--from-code=UTF-8"¹ to XGETTEXT_OPTIONS in po/Makevars.

¹http://linux.die.net/man/1/xgettext
Comment 3 Christian Hesse 2014-03-18 19:47:43 CET
Created attachment 1351 [details]
allow UTF-8 charaters in translatable strings

Like this? Looks like it compiles fine.