Bug 3016 - Messages encrypted with attachments or encrypted and signed are not properly indicated
Summary: Messages encrypted with attachments or encrypted and signed are not properly ...
Status: RESOLVED INVALID
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: UI/Message List (show other bugs)
Version: 3.9.2
Hardware: PC Linux
: P3 normal
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-10-17 00:43 CEST by Ian Nartowicz
Modified: 2013-10-21 15:36 CEST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Nartowicz 2013-10-17 00:43:54 CEST
There is an icon in the "paper clip" column to indicate when a message is encrypted and has an attachment, but such messages are just shown as being encrypted.  In the message view, the mime icons, including the attachment, show no indication of being encrypted although I know that the encrypted emblem used to get pasted on (in Sylpheed?).

There is also an icon that should be shown in the same column to indicate when a message is both encrypted and signed, but such messages are just shown as being encrypted.  The mime icon has the signed emblem pasted in and a signature attachment (with PGP mime) but no sign of an encrypted emblem.

There is no icon to indicate when a message is encrypted, signed, and has attachments.  Such messages just show as being signed and having an attachment.  The mime icons for both the plain text and attachment has the signed emblem pasted in.
Comment 1 Ian Nartowicz 2013-10-20 15:27:24 CEST
The icon legend shows the correct icon for the encrypted with attachments case, just not the message list attachment column, so the icon is being found and correctly imported but not picked up.  The encrypted and signed example is not in the legend.
Comment 2 Paul 2013-10-20 18:11:18 CEST
It depends on how the message block is created.

Normally the signature is within the encrypted block, so there is no way to tell that the message is signed and encrypted.

The only way to see that icon is to sign an encrypted block.
Comment 3 Ian Nartowicz 2013-10-20 18:37:36 CEST
Got it.  When I encrypted a message, then added a signature attachment afterwards, an icon showed up :)  The wrong icon :(  I see the icon from the default theme even when I am using a different theme with a different icon.  In stock_pixmaps.c, the filename for this pixmap is given as key_gpg_signed_xpm insstead of key_gpg_signed.  If I rename a theme icon from key_gpg_signed.png to key_gpg_signed_xpm.png then it appears.

Still the encrypted and has attachments icon never shows on a message that is encrypted and has attachments, only in the icon legend box.  Can't see why from the code.
Comment 4 Ian Nartowicz 2013-10-20 18:58:04 CEST
Got the other one too, with clues from your explanation.

The "message is encrypted and has attachments" icon shows up when I send an inline-encrypted message plus non-encrypted attachments.  It doesn't show up when I use PGP-MIME to encrypt everything including the attachments.  I think it should.  The attachments are detectable even if the content is not understood.  The message view even shows each attachment separately (as application/pgp-encrypted) even before they are decrypted.

Do we much care about inline-encrypted messages these days?  Isn't it mostly Windows users that send them ;)
Comment 5 Ian Nartowicz 2013-10-21 00:11:43 CEST
Still finding oddities.  In my sent folder message list signed emails, including in combination with attachments, do not have an icon in the paper-clip column until I select the message.  When I select the correct icon appears.
Comment 6 Ian Nartowicz 2013-10-21 15:36:56 CEST
The tooltip associated with the icon for an inline-encrypted message body with a signature attachment is simply "Signed".  It should probably be something more explanatory as to why this strange symbol shows up.  "Signed and encrypted" at a minimum, but preferably something more like "Signed, inline-encrypted" or "Signed, message text encrypted".

Along the same lines, as currently defined, the tooltip (and icon legend) for signed and having attachments (if it is going to continue only be shown in the specific instance of an inline-encrypted message body and non-encrypted attachments, should indicate that fact.  For example: "Encrypted, non-encrypted attachment(s)".  Possibly even the simply encrypted tooltip that appears for mime-encrypted messages could then indicate that such a message might well include attachments and a signature.

Further to that case, the emblem that is shown on the message body never indicates that it is encrypted (for example, if the decryption fails or is cancelled) because it always receives a pgp_signed emblem of some sort.  Not easy to change though, it would probably require two emblems.  That would give the option to have en emblem for decrypted attachments though, which might be nice.