Bug 2891 - Ability to toggle debug mode for a running instance
Summary: Ability to toggle debug mode for a running instance
Status: RESOLVED FIXED
Alias: None
Product: Claws Mail
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.9.1
Hardware: PC Linux
: P3 enhancement
Assignee: users
URL:
Depends on:
Blocks:
 
Reported: 2013-03-13 16:37 CET by Darko
Modified: 2013-03-20 11:43 CET (History)
2 users (show)

See Also:


Attachments
Debug toggle patch (2.21 KB, patch)
2013-03-13 16:38 CET, Darko
no flags Details | Diff
Updated patch (2.74 KB, patch)
2013-03-13 18:41 CET, Darko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darko 2013-03-13 16:37:09 CET
The attached patch adds ability to toggle debug mode for a running instance.
How to use it:
claws-mail --debug-toggle

If debug mode is enabled it will be disabled.
If debug mode is disabled it will be enabled.
Comment 1 Darko 2013-03-13 16:38:08 CET
Created attachment 1242 [details]
Debug toggle patch
Comment 2 Colin Leroy 2013-03-13 16:39:34 CET
Cool patch! I'm going to get pedantic and say I'd prefer --toggle-debug :)
Comment 3 Ricardo Mones 2013-03-13 17:07:14 CET
Seconded, --toggle-debug sounds better.

I'm going to be even more pedantic and say the patch doesn't update the manpage (doc/man/claws-mail.1) with the new option ;-)
Comment 4 Darko 2013-03-13 17:52:08 CET
Thanks, I will upload updated patch later.
Comment 5 Darko 2013-03-13 18:41:29 CET
Created attachment 1246 [details]
Updated patch

The option is now called --toggle-debug
Updated manual page
Comment 6 Colin Leroy 2013-03-20 11:43:31 CET
Hi Darko,

Applied:

commit 9570a00c49015c359d048085cdb303efedec7e18
Author: Colin Leroy <colin@colino.net>
Date:   Wed Mar 20 11:34:34 2013 +0100

    Fix bug #2891, "Ability to toggle debug mode for a running instance"
    Patch by Darko Coruga
Comment 7 users 2013-03-20 15:06:30 CET

    
Comment 8 users 2013-03-20 15:06:44 CET
Changes related to this bug have been committed.
Please check latest Git and update the bug accordingly.
You can also get the patch from:
http://git.claws-mail.org/

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=cbfce9aaed739b5ec4979241653cc45d5641916e
Author: Colin Leroy <colin@colino.net>
Date:   Wed Mar 20 12:43:13 2013 +0100

    One more, for mail test

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=60859b9fde10bc4ad70c5e253fea523da0536759
Author: Colin Leroy <colin@colino.net>
Date:   Wed Mar 20 12:34:48 2013 +0100

    Another test

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=0cfa853403701649e804c89c63820eaf1be2a026
Author: Colin Leroy <colin@colino.net>
Date:   Wed Mar 20 11:58:30 2013 +0100

    Fixing README, testing Gitzilla (see bug #2892)

http://git.claws-mail.org/?p=claws.git;a=commitdiff;h=9570a00c49015c359d048085cdb303efedec7e18
Author: Colin Leroy <colin@colino.net>
Date:   Wed Mar 20 11:34:34 2013 +0100

    Fix bug #2891, "Ability to toggle debug mode for a running instance"
    Patch by Darko Coruga